D22275: [Svg] Fix porting error from QRegExp::exactMatch

2019-07-05 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:214838313d9f: [Svg] Fix porting error from 
QRegExp::exactMatch (authored by broulik).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22275?vs=61152&id=61213

REVISION DETAIL
  https://phabricator.kde.org/D22275

AFFECTED FILES
  src/plasma/svg.cpp

To: broulik, #plasma, apol
Cc: kde-frameworks-devel, ndavis, LeGast00n, michaelh, ngraham, bruns


D22275: [Svg] Fix porting error from QRegExp::exactMatch

2019-07-04 Thread Aleix Pol Gonzalez
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D22275

To: broulik, #plasma, apol
Cc: kde-frameworks-devel, ndavis, LeGast00n, michaelh, ngraham, bruns


D22275: [Svg] Fix porting error from QRegExp::exactMatch

2019-07-04 Thread Noah Davis
ndavis added a comment.


  I can confirm this fixes the problem here: 
https://phabricator.kde.org/D22147#490563

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D22275

To: broulik, #plasma, apol
Cc: kde-frameworks-devel, ndavis, LeGast00n, michaelh, ngraham, bruns


D22275: [Svg] Fix porting error from QRegExp::exactMatch

2019-07-04 Thread Kai Uwe Broulik
broulik created this revision.
broulik added reviewers: Plasma, apol.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  The `CACHE_ID_NATURAL_SIZE` adds stuff around the argument string, so 
explicitly move the `^` and `$` outside.

TEST PLAN
  Untested, asked @ndavis to check on his machine where the issue shows

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D22275

AFFECTED FILES
  src/plasma/svg.cpp

To: broulik, #plasma, apol
Cc: kde-frameworks-devel, ndavis, LeGast00n, michaelh, ngraham, bruns