D22413: Fix build after 0b2fe3cf21

2019-07-12 Thread Daniel Vrátil 
This revision was automatically updated to reflect the committed changes.
Closed by commit R244:95e9d5f22ea3: Fix build after 0b2fe3cf21 (authored by 
dvratil).

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22413?vs=61628=61633

REVISION DETAIL
  https://phabricator.kde.org/D22413

AFFECTED FILES
  src/lib/text/kstringhandler.cpp

To: dvratil, dfaure, broulik
Cc: broulik, kde-frameworks-devel, mlaurent, LeGast00n, michaelh, ngraham, bruns

D22413: Fix build after 0b2fe3cf21

2019-07-12 Thread Kai Uwe Broulik 
broulik accepted this revision.
broulik added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> kstringhandler.cpp:346
>  int length = 0;
>  auto chrs = text.toUcs4();
>  for (auto chr : chrs) {

for the reference, `toUcs4()` returns a `QVector`

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22413

To: dvratil, dfaure, broulik
Cc: broulik, kde-frameworks-devel, mlaurent, LeGast00n, michaelh, ngraham, bruns

D22413: Fix build after 0b2fe3cf21

2019-07-12 Thread Daniel Vrátil 
dvratil created this revision.
dvratil added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dvratil requested review of this revision.

REVISION SUMMARY
  QVector is not unused in kstringhandler.cpp

TEST PLAN
  kcoreaddons master builds against Qt 5.12.4

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22413

AFFECTED FILES
  src/lib/text/kstringhandler.cpp

To: dvratil, dfaure
Cc: kde-frameworks-devel, mlaurent, LeGast00n, michaelh, ngraham, bruns