D22724: [WIP] Add ECMAddQtDesignerPlugin
kossebau updated this revision to Diff 62676. kossebau added a comment. - escape strings to be used as strings in C++ code - use Qt5Core version to decide whether checking only for QtUiPlugin is enough REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22724?vs=62653&id=62676 BRANCH addqtdesignerplugin REVISION DETAIL https://phabricator.kde.org/D22724 AFFECTED FILES docs/module/ECMAddQtDesignerPlugin.rst modules/ECMAddQtDesignerPlugin.cmake To: kossebau Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, bencreasy, michaelh, ngraham, bruns
D22724: [WIP] Add ECMAddQtDesignerPlugin
kossebau added a dependent revision: D22785: [WIP] Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22724 To: kossebau Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, bencreasy, michaelh, ngraham, bruns
D22724: [WIP] Add ECMAddQtDesignerPlugin
kossebau added a dependent revision: D22784: [WIP] Deprecate kgendesignerplugin, drop bundle plugim for all KF5 widgets. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22724 To: kossebau Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, bencreasy, michaelh, ngraham, bruns
D22724: [WIP] Add ECMAddQtDesignerPlugin
kossebau updated this revision to Diff 62653. kossebau added a comment. add more options: DEFAULT_HEADER_CASE, DEFAULT_HEADER_EXTENSION, DEFAULT_ICON_DIR REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22724?vs=62642&id=62653 BRANCH addqtdesignerplugin REVISION DETAIL https://phabricator.kde.org/D22724 AFFECTED FILES docs/module/ECMAddQtDesignerPlugin.rst modules/ECMAddQtDesignerPlugin.cmake To: kossebau Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, bencreasy, michaelh, ngraham, bruns
D22724: [WIP] Add ECMAddQtDesignerPlugin
kossebau added a dependent revision: D22778: [WIP] Restore option to create a Qt Designer plugin. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22724 To: kossebau Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, bencreasy, michaelh, ngraham, bruns
D22724: [WIP] Add ECMAddQtDesignerPlugin
kossebau added a dependent revision: D22777: [WIP] Use ECMAddQtDesignerPlugin instead of KF5DesignerPlugin. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22724 To: kossebau Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, bencreasy, michaelh, ngraham, bruns
D22724: [WIP] Add ECMAddQtDesignerPlugin
kossebau added a dependent revision: D22776: [WIP] Use ECMAddQtDesignerPlugin instead of KF5DesignerPlugin. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22724 To: kossebau Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, bencreasy, michaelh, ngraham, bruns
D22724: [WIP] Add ECMAddQtDesignerPlugin
kossebau updated this revision to Diff 62642. kossebau added a comment. - more code comments - fix icon file existance check REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22724?vs=62618&id=62642 BRANCH addqtdesignerplugin REVISION DETAIL https://phabricator.kde.org/D22724 AFFECTED FILES docs/module/ECMAddQtDesignerPlugin.rst modules/ECMAddQtDesignerPlugin.cmake To: kossebau Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, bencreasy, michaelh, ngraham, bruns
D22724: [WIP] Add ECMAddQtDesignerPlugin
kossebau updated this revision to Diff 62618. kossebau added a comment. - API DOX: explain arguments - add argument to make it work for Okteta's extra code - avoid rebuilding if generated file did not change - place generated files in subdir for namespacing REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22724?vs=62492&id=62618 BRANCH addqtdesignerplugin REVISION DETAIL https://phabricator.kde.org/D22724 AFFECTED FILES docs/module/ECMAddQtDesignerPlugin.rst modules/ECMAddQtDesignerPlugin.cmake To: kossebau Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, bencreasy, michaelh, ngraham, bruns
D22724: [WIP] Add ECMAddQtDesignerPlugin
kossebau added a dependent revision: D22725: [WIP] Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22724 To: kossebau Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, bencreasy, michaelh, ngraham, bruns
D22724: [WIP] Add ECMAddQtDesignerPlugin
kossebau edited the summary of this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22724 To: kossebau Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, bencreasy, michaelh, ngraham, bruns
D22724: [WIP] Add ECMAddQtDesignerPlugin
kossebau created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Goal is to replace KDesignerPlugin. So options & defaults are tried to be met. Only difference is the need to define the widgets in cmake code, using a util method, instead of external ".widgets" files. Porting of ".widgets" files basically means: copy content into cmake, transform ini code into arguments to util method. Key names need a bit of adaption, current names are open for dicussion. Porting example: [KActionSelector] IncludeFile=kactionselector.h ToolTip=A widget for selecting and arranging actions/objects Group=Views (KF5) gets ecm_qtdesignerplugin_widget(KActionSelector INCLUDE_FILE kactionselector.h TOOLTIP "A widget for selecting and arranging actions/objects" GROUP "Views (KF5)" ) REPOSITORY R240 Extra CMake Modules BRANCH addqtdesignerplugin REVISION DETAIL https://phabricator.kde.org/D22724 AFFECTED FILES modules/ECMAddQtDesignerPlugin.cmake To: kossebau Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, bencreasy, michaelh, ngraham, bruns
