D22724: Add ECMAddQtDesignerPlugin

2019-08-05 Thread Friedrich W. H. Kossebau 
This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:6709de184aa3: Add ECMAddQtDesignerPlugin (authored by 
kossebau).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22724?vs=62676=63136

REVISION DETAIL
  https://phabricator.kde.org/D22724

AFFECTED FILES
  docs/module/ECMAddQtDesignerPlugin.rst
  modules/ECMAddQtDesignerPlugin.cmake

To: kossebau, #build_system, #frameworks
Cc: apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, 
bencreasy, michaelh, ngraham, bruns

D22724: Add ECMAddQtDesignerPlugin

2019-08-01 Thread Friedrich W. H. Kossebau 
kossebau added a comment.


  Seems people so far are fine with this, any comments were rather positive. No 
changes requested.
  
  So unless someone objects, would then proceed to push soon after KF 5.61 has 
been branched upcoming WE. Scheduling myself for Tuesday, August 6th currently, 
so there are some weeks to collect feedback from unreleased master branch 
experience.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D22724

To: kossebau, #build_system, #frameworks
Cc: apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, 
bencreasy, michaelh, ngraham, bruns

D22724: Add ECMAddQtDesignerPlugin

2019-07-28 Thread Aleix Pol Gonzalez 
apol added a comment.


  +1 LGTM

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D22724

To: kossebau, #build_system, #frameworks
Cc: apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, 
bencreasy, michaelh, ngraham, bruns

D22724: Add ECMAddQtDesignerPlugin

2019-07-28 Thread Friedrich W. H. Kossebau 
kossebau retitled this revision from "[WIP] Add ECMAddQtDesignerPlugin" to "Add 
ECMAddQtDesignerPlugin".
kossebau edited the summary of this revision.
kossebau added reviewers: Build System, Frameworks.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D22724

To: kossebau, #build_system, #frameworks
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, bencreasy, 
michaelh, ngraham, bruns