D22776: [WIP] Use ECMAddQtDesignerPlugin instead of KF5DesignerPlugin
kossebau abandoned this revision. kossebau added a comment. kelibs4support still sports the `KDEUIMacros.cmale` file, which defines a macro `KDE4_ADD_WIDGET_FILES`, which uses KF5DESIGNERPLUGIN_GENERATOR_EXECUTABLE, so has a runtime dependency on kdesignerplugin with the development files. In that case it does not make that much sense to also remove it as build time dependency? Potentially resulting in packagers changing too much things, and forgetting about the run time dependency? Thus discarding for now. REPOSITORY R239 KDELibs4Support REVISION DETAIL https://phabricator.kde.org/D22776 To: kossebau Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns
D22776: [WIP] Use ECMAddQtDesignerPlugin instead of KF5DesignerPlugin
kossebau updated this revision to Diff 62654. kossebau added a comment. make use of DEFAULT_ICON_DIR REPOSITORY R239 KDELibs4Support CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22776?vs=62641=62654 BRANCH useecmaddqtdesignerplugin REVISION DETAIL https://phabricator.kde.org/D22776 AFFECTED FILES CMakeLists.txt src/CMakeLists.txt src/classpreviews.cpp src/classpreviews.h src/designer/CMakeLists.txt src/designer/classpreviews.cpp src/designer/classpreviews.h src/kdedeprecated.qrc src/kdedeprecated.widgets To: kossebau Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns
D22776: [WIP] Use ECMAddQtDesignerPlugin instead of KF5DesignerPlugin
kossebau added a dependency: D22724: [WIP] Add ECMAddQtDesignerPlugin. REPOSITORY R239 KDELibs4Support REVISION DETAIL https://phabricator.kde.org/D22776 To: kossebau Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns
D22776: [WIP] Use ECMAddQtDesignerPlugin instead of KF5DesignerPlugin
kossebau created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REPOSITORY R239 KDELibs4Support BRANCH useecmaddqtdesignerplugin REVISION DETAIL https://phabricator.kde.org/D22776 AFFECTED FILES CMakeLists.txt src/CMakeLists.txt src/classpreviews.cpp src/classpreviews.h src/designer/CMakeLists.txt src/designer/classpreviews.cpp src/designer/classpreviews.h src/kdedeprecated.qrc src/kdedeprecated.widgets To: kossebau Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns