D23418: KStartupInfo: drop dead code for removing quotes from data values

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R278:14519d311709: KStartupInfo: drop dead code for removing 
quotes from data values (authored by kossebau).

REPOSITORY
  R278 KWindowSystem

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23418?vs=64530&id=65612

REVISION DETAIL
  https://phabricator.kde.org/D23418

AFFECTED FILES
  src/kstartupinfo.cpp

To: kossebau, #plasma, hein, broulik, #kwin, zzag
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23418: KStartupInfo: drop dead code for removing quotes from data values

[Vlad Zagorodniy]

zzag accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R278 KWindowSystem

BRANCH
  dropdeadcodeforremovingquotesfromstartupdatavalue

REVISION DETAIL
  https://phabricator.kde.org/D23418

To: kossebau, #plasma, hein, broulik, #kwin, zzag
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23418: KStartupInfo: drop dead code for removing quotes from data values

[Friedrich W. H. Kossebau]

kossebau added a reviewer: KWin.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D23418

To: kossebau, #plasma, hein, broulik, #kwin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23418: KStartupInfo: drop dead code for removing quotes from data values

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Plasma, hein, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  get_fields() already cares for removing the quotes, the bits in get_str()
  are thus already operating on the final string, as well as it is broken
  in the calculation of the text length to copy.
  
  Possibly were left-over from initial code drafts, as all this logic was
  already in the initial commit to kdelibs in e5b75f8409e7 


TEST PLAN
  Startup notification still works as before, quoted values like
  Description="Launching Dolphin"
  are still read in as before

REPOSITORY
  R278 KWindowSystem

BRANCH
  dropdeadcodeforremovingquotesfromstartupdatavalue

REVISION DETAIL
  https://phabricator.kde.org/D23418

AFFECTED FILES
  src/kstartupinfo.cpp

To: kossebau, #plasma, hein, broulik
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns