D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

2019-10-01 Thread Méven Car 
This revision was automatically updated to reflect the committed changes.
Closed by commit R320:52175ce07389: Add two special cases url 
recentlyused:/files and recentlyused:/folders (authored by meven).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23742?vs=67102&id=67103

REVISION DETAIL
  https://phabricator.kde.org/D23742

AFFECTED FILES
  recentlyused/recentlyused.cpp
  recentlyused/recentlyused.h

To: meven, ivan, ngraham, #frameworks
Cc: kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, 
fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

2019-10-01 Thread Méven Car 
meven added a comment.


  The /folders path is /locations in fact

REPOSITORY
  R320 KIO Extras

BRANCH
  arcpatch-D23742

REVISION DETAIL
  https://phabricator.kde.org/D23742

To: meven, ivan, ngraham, #frameworks
Cc: kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, 
fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

2019-10-01 Thread Méven Car 
meven updated this revision to Diff 67102.
meven added a comment.


  Correct ?type use with /files : ?type overrules /files, since they are 
aggregated with ORs

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23742?vs=65959&id=67102

BRANCH
  arcpatch-D23742

REVISION DETAIL
  https://phabricator.kde.org/D23742

AFFECTED FILES
  recentlyused/recentlyused.cpp
  recentlyused/recentlyused.h

To: meven, ivan, ngraham, #frameworks
Cc: kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, 
fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

2019-09-13 Thread Nathaniel Graham 
ngraham added a comment.


  Please do! It's already accepted. :)

REPOSITORY
  R320 KIO Extras

BRANCH
  arcpatch-D23742

REVISION DETAIL
  https://phabricator.kde.org/D23742

To: meven, ivan, ngraham, #frameworks
Cc: kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, 
fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

2019-09-13 Thread Méven Car 
meven marked 2 inline comments as done.
meven added a comment.


  I will land this soonish if no one has any objections.

REPOSITORY
  R320 KIO Extras

BRANCH
  arcpatch-D23742

REVISION DETAIL
  https://phabricator.kde.org/D23742

To: meven, ivan, ngraham, #frameworks
Cc: kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, 
fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

2019-09-13 Thread Méven Car 
meven updated this revision to Diff 65959.
meven added a comment.


  Allow users to use ?type filter with /files path

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23742?vs=65597&id=65959

BRANCH
  arcpatch-D23742

REVISION DETAIL
  https://phabricator.kde.org/D23742

AFFECTED FILES
  recentlyused/recentlyused.cpp
  recentlyused/recentlyused.h

To: meven, ivan, ngraham, #frameworks
Cc: kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, 
fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

2019-09-10 Thread Nathaniel Graham 
ngraham added inline comments.

INLINE COMMENTS

> meven wrote in recentlyused.cpp:98
> Should we allow the filtering through type with /files path ?
> I am thinking I should change that.

Sure, sounds like a neat bonus feature.

REPOSITORY
  R320 KIO Extras

BRANCH
  arcpatch-D23742

REVISION DETAIL
  https://phabricator.kde.org/D23742

To: meven, ivan, ngraham, #frameworks
Cc: kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, 
fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

2019-09-10 Thread Méven Car 
meven added inline comments.

INLINE COMMENTS

> recentlyused.cpp:98
> -// handles type aka mimetype
> -if (urlQuery.hasQueryItem(QStringLiteral("type"))) {
> -const auto typeValue = 
> urlQuery.queryItemValue(QStringLiteral("type"));

Should we allow the filtering through type with /files path ?
I am thinking I should change that.

REPOSITORY
  R320 KIO Extras

BRANCH
  arcpatch-D23742

REVISION DETAIL
  https://phabricator.kde.org/D23742

To: meven, ivan, ngraham, #frameworks
Cc: kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, 
fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

2019-09-07 Thread Ivan Čukić 
ivan accepted this revision.

REPOSITORY
  R320 KIO Extras

BRANCH
  arcpatch-D23742

REVISION DETAIL
  https://phabricator.kde.org/D23742

To: meven, ivan, ngraham, #frameworks
Cc: kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, 
fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

2019-09-07 Thread Nathaniel Graham 
ngraham accepted this revision.

REPOSITORY
  R320 KIO Extras

BRANCH
  arcpatch-D23742

REVISION DETAIL
  https://phabricator.kde.org/D23742

To: meven, ivan, ngraham, #frameworks
Cc: kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, 
fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

2019-09-07 Thread Méven Car 
meven updated this revision to Diff 65597.
meven added a comment.


  Use new folder-open-recent for /locations

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23742?vs=65492&id=65597

BRANCH
  arcpatch-D23742

REVISION DETAIL
  https://phabricator.kde.org/D23742

AFFECTED FILES
  recentlyused/recentlyused.cpp
  recentlyused/recentlyused.h

To: meven, ivan, ngraham, #frameworks
Cc: kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, 
fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

2019-09-05 Thread Méven Car 
meven updated this revision to Diff 65492.
meven added a comment.


  Use Terms::Type::directories()

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23742?vs=65484&id=65492

BRANCH
  arcpatch-D23742

REVISION DETAIL
  https://phabricator.kde.org/D23742

AFFECTED FILES
  recentlyused/recentlyused.cpp
  recentlyused/recentlyused.h

To: meven, ivan, ngraham, #frameworks
Cc: kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, 
fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

2019-09-05 Thread Méven Car 
meven updated this revision to Diff 65484.
meven added a comment.


  grammar

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23742?vs=65474&id=65484

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23742

AFFECTED FILES
  recentlyused/recentlyused.cpp
  recentlyused/recentlyused.h

To: meven, ivan, ngraham, #frameworks
Cc: kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, 
fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

2019-09-05 Thread Méven Car 
meven updated this revision to Diff 65474.
meven added a comment.


  typo

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23742?vs=65473&id=65474

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23742

AFFECTED FILES
  recentlyused/recentlyused.cpp
  recentlyused/recentlyused.h

To: meven, ivan, ngraham, #frameworks
Cc: kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, 
fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

2019-09-05 Thread Méven Car 
meven updated this revision to Diff 65473.
meven added a comment.


  Replace /folders by /locations, add some documentation

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23742?vs=65470&id=65473

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23742

AFFECTED FILES
  recentlyused/recentlyused.cpp
  recentlyused/recentlyused.h

To: meven, ivan, ngraham, #frameworks
Cc: kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, 
fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

2019-09-05 Thread Nathaniel Graham 
ngraham added a dependent revision: D7446: [Places panel] Revamp the Recently 
Saved section.

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23742

To: meven, ivan, ngraham, #frameworks
Cc: kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, 
fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

2019-09-05 Thread Méven Car 
meven updated this revision to Diff 65470.
meven added a comment.


  Add some const

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23742?vs=65467&id=65470

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23742

AFFECTED FILES
  recentlyused/recentlyused.cpp
  recentlyused/recentlyused.h

To: meven, ivan, ngraham, #frameworks
Cc: kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, 
fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

2019-09-05 Thread Ivan Čukić 
ivan accepted this revision.

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23742

To: meven, ivan, ngraham, #frameworks
Cc: kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, 
fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

2019-09-05 Thread Méven Car 
meven updated this revision to Diff 65467.
meven added a comment.


  Rephrase 'Recent Folders' to 'Recent Locations'

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23742?vs=65449&id=65467

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23742

AFFECTED FILES
  recentlyused/recentlyused.cpp
  recentlyused/recentlyused.h

To: meven, ivan, ngraham, #frameworks
Cc: kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, 
fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

2019-09-05 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  After applying the full patchset, this works great. It's //exactly// what I 
was hoping for! 👏

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23742

To: meven, ivan, ngraham, #frameworks
Cc: kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, 
fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

2019-09-05 Thread Méven Car 
meven created this revision.
meven added reviewers: ivan, ngraham, Frameworks.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  Depends on D23736 

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23742

AFFECTED FILES
  recentlyused/recentlyused.cpp
  recentlyused/recentlyused.h

To: meven, ivan, ngraham, #frameworks
Cc: kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, 
fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov