D23930: Set XCB to required if building the X backend

2019-09-13 Thread Allen Winter 
winterz added a comment.


  +1
  will fix the problem I reported.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D23930

To: davidedmundson, zzag
Cc: winterz, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23930: Set XCB to required if building the X backend

2019-09-13 Thread David Edmundson 
This revision was automatically updated to reflect the committed changes.
Closed by commit R278:aaacf7d5c206: Set XCB to required if building the X 
backend (authored by davidedmundson).

REPOSITORY
  R278 KWindowSystem

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23930?vs=65999&id=66002

REVISION DETAIL
  https://phabricator.kde.org/D23930

AFFECTED FILES
  CMakeLists.txt

To: davidedmundson, zzag
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23930: Set XCB to required if building the X backend

2019-09-13 Thread Vlad Zahorodnii 
zzag accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R278 KWindowSystem

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23930

To: davidedmundson, zzag
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23930: Set XCB to required if building the X backend

2019-09-13 Thread David Edmundson 
davidedmundson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Otherwise builds could fail on missing dependencies at build time,
  rather than configure time.
  
  This was previously broken, but my extra dependency on XCB::Res made it
  noticable.

REPOSITORY
  R278 KWindowSystem

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23930

AFFECTED FILES
  CMakeLists.txt

To: davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns