D23991: GIT_SILENT fix comment about passwords in debug output

2019-09-16 Thread Ahmad Samir 
ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  QUrls in debug output always have the password removed (upstream impl.)

REPOSITORY
  R241 KIO

BRANCH
  ahmad/url-debug-output-passwords (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23991

AFFECTED FILES
  src/core/kcoredirlister.cpp

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23991: GIT_SILENT fix comment about passwords in debug output

2019-09-16 Thread David Faure 
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  There isn't even a QString around in this code, so you could just remove the 
comment altogether.

REPOSITORY
  R241 KIO

BRANCH
  ahmad/url-debug-output-passwords (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23991

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23991: GIT_SILENT fix comment about passwords in debug output

2019-09-16 Thread Ahmad Samir 
ahmadsamir updated this revision to Diff 66227.
ahmadsamir added a comment.


  Remove redundant comments

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23991?vs=66217&id=66227

BRANCH
  ahmad/url-debug-output-passwords (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23991

AFFECTED FILES
  src/core/kcoredirlister.cpp

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23991: GIT_SILENT fix comment about passwords in debug output

2019-09-16 Thread David Faure 
dfaure accepted this revision.

REPOSITORY
  R241 KIO

BRANCH
  ahmad/url-debug-output-passwords (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23991

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23991: GIT_SILENT fix comment about passwords in debug output

2019-09-16 Thread David Faure 
dfaure closed this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23991

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns