D24004: Teach kwaylandscanner about PrimarySelection

2020-02-18 Thread David Edmundson
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  I'm skeptical that kwaylandscanner adds anything, especially when we want to 
pretty much clone a class, but sure.
  
  In terms of the names.
  
  As for V1. We're not entirely consistent.
  
  For anything unstable with the z prefix, it's probably worth it.
  Otherwise we're trying to write a stable interface round something that 
inherently isn't stable...which is asking for trouble.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24004

To: gladhorn, #kwin, davidedmundson
Cc: meven, davidedmundson, romangg, zzag, kde-frameworks-devel, LeGast00n, 
cblack, GB_2, michaelh, ngraham, bruns


D24004: Teach kwaylandscanner about PrimarySelection

2020-02-18 Thread Méven Car
meven added a comment.


  ping reviewers :)

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D24004

To: gladhorn, #kwin
Cc: meven, davidedmundson, romangg, zzag, kde-frameworks-devel, LeGast00n, 
cblack, GB_2, michaelh, ngraham, bruns


D24004: Teach kwaylandscanner about PrimarySelection

2019-09-20 Thread Frederik Gladhorn
gladhorn added subscribers: zzag, romangg, davidedmundson.
gladhorn added a comment.


  @romangg and @davidedmundson  any comments? I think @zzag  prefers the class 
names without the V1. I'd like to progress on this step by step and the 
generator at least gives a good starting point.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D24004

To: gladhorn, #kwin
Cc: davidedmundson, romangg, zzag, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns


D24004: Teach kwaylandscanner about PrimarySelection

2019-09-16 Thread Frederik Gladhorn
gladhorn created this revision.
gladhorn added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
gladhorn requested review of this revision.

REVISION SUMMARY
  This allows generating the skeleton classes for the primary selection 
protocol.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24004

AFFECTED FILES
  src/tools/mapping.txt

To: gladhorn, #kwin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns