D24429: [ConfigModule] Expose mainUi component status and error string

2019-10-11 Thread Friedrich W. H. Kossebau 
kossebau added a comment.


  Seems this broke the windows build on CI for some reason, please have a look:
  
https://build.kde.org/view/Failing/job/Frameworks/job/kcmutils/job/kf5-qt5%20WindowsMSVCQt5.13/17/

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D24429

To: broulik, #plasma, mart
Cc: kossebau, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24429: [ConfigModule] Expose mainUi component status and error string

2019-10-08 Thread Kai Uwe Broulik 
This revision was automatically updated to reflect the committed changes.
Closed by commit R296:2c2942cee9ec: [ConfigModule] Expose mainUi component 
status and error string (authored by broulik).

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24429?vs=67355=67494

REVISION DETAIL
  https://phabricator.kde.org/D24429

AFFECTED FILES
  src/quickaddons/configmodule.cpp
  src/quickaddons/configmodule.h

To: broulik, #plasma, mart
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24429: [ConfigModule] Expose mainUi component status and error string

2019-10-08 Thread Marco Martin 
mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D24429

To: broulik, #plasma, mart
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24429: [ConfigModule] Expose mainUi component status and error string

2019-10-07 Thread Kai Uwe Broulik 
broulik added a comment.


  > Is the text in the window mouse-selectable?
  
  I don't think so (didn't test, just read the code) but should be trivial to 
add.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D24429

To: broulik, #plasma
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24429: [ConfigModule] Expose mainUi component status and error string

2019-10-06 Thread Nathaniel Graham 
ngraham added a comment.


  Is the text in the window mouse-selectable? That would be really nice.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D24429

To: broulik, #plasma
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24429: [ConfigModule] Expose mainUi component status and error string

2019-10-05 Thread Kai Uwe Broulik 
broulik added a dependent revision: D24430: [KCModuleLoader] Show error when 
QML fails to load.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D24429

To: broulik, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24429: [ConfigModule] Expose mainUi component status and error string

2019-10-05 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D24429

AFFECTED FILES
  src/quickaddons/configmodule.cpp
  src/quickaddons/configmodule.h

To: broulik, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns