D24559: simplify the url parsing

2019-10-11 Thread Harald Sitter 
sitter created this revision.
sitter added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  all urls need to have their ports stripped and text set, so de-duplicate
  the shared code out of the conditional branches to prevent bugs from
  making changes in one branch but not the other

TEST PLAN
  saving and changing proxy settings continues to work

REPOSITORY
  R241 KIO

BRANCH
  simplify-proxy-load

REVISION DETAIL
  https://phabricator.kde.org/D24559

AFFECTED FILES
  src/kcms/kio/kproxydlg.cpp

To: sitter, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24559: simplify the url parsing

2019-10-11 Thread Aleix Pol Gonzalez 
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  simplify-proxy-load

REVISION DETAIL
  https://phabricator.kde.org/D24559

To: sitter, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24559: simplify the url parsing

2019-10-14 Thread Harald Sitter 
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:c904cbcb9876: simplify the url parsing (authored by 
sitter).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24559?vs=67703&id=67881

REVISION DETAIL
  https://phabricator.kde.org/D24559

AFFECTED FILES
  src/kcms/kio/kproxydlg.cpp

To: sitter, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns