D24590: Port KSslErrorUiData to QSslError

2019-10-14 Thread Volker Krause 
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:77fce361d9ba: Port KSslErrorUiData to QSslError (authored 
by vkrause).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D24590?vs=67828=67918#toc

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24590?vs=67828=67918

REVISION DETAIL
  https://phabricator.kde.org/D24590

AFFECTED FILES
  src/core/ksslcertificatemanager.cpp
  src/core/ksslerroruidata.cpp
  src/core/ksslerroruidata_p.h
  src/widgets/sslui.cpp

To: vkrause, dfaure, aacid
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24590: Port KSslErrorUiData to QSslError

2019-10-14 Thread Volker Krause 
vkrause added a comment.


  In D24590#546528 , @aacid wrote:
  
  > Do we have tests for the thing you discovered breaks? Do we need them?
  
  
  There's almost no test coverage for this unfortunately, and yes, I'd feel 
much better if we had that. I looked at adding tests as part of this work, but 
unfortunately that is rather complicated as there is a D-Bus daemon involved.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24590

To: vkrause, dfaure, aacid
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24590: Port KSslErrorUiData to QSslError

2019-10-13 Thread Albert Astals Cid 
aacid accepted this revision.
aacid added a comment.


  Do we have tests for the thing you discovered breaks? Do we need them?

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24590

To: vkrause, dfaure, aacid
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24590: Port KSslErrorUiData to QSslError

2019-10-13 Thread Volker Krause 
vkrause updated this revision to Diff 67828.
vkrause added a comment.
This revision is now accepted and ready to land.


  Deal with errors with full QSslError level of detail until kssld is ported, 
make variables const.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24590?vs=67785=67828

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24590

AFFECTED FILES
  src/core/ksslcertificatemanager.cpp
  src/core/ksslerroruidata.cpp
  src/core/ksslerroruidata_p.h
  src/widgets/sslui.cpp

To: vkrause, dfaure, aacid
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24590: Port KSslErrorUiData to QSslError

2019-10-13 Thread Volker Krause 
vkrause planned changes to this revision.
vkrause added a comment.


  This actually breaks things when the error comes from a Qt source rather than 
a KIO one, as we now carry the QSslError level of detail forward far enough and 
compare it to the stored KSslError. This is a temporary problem until the kssld 
side is ported too, but it nevertheless needs a workaround until that is done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24590

To: vkrause, dfaure, aacid
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24590: Port KSslErrorUiData to QSslError

2019-10-12 Thread Albert Astals Cid 
aacid accepted this revision.
aacid added a comment.
This revision is now accepted and ready to land.


  Looks good, maybe i can even convince you to make fatalErrors and 
remainingErrors const?

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24590

To: vkrause, dfaure, aacid
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24590: Port KSslErrorUiData to QSslError

2019-10-12 Thread Volker Krause 
vkrause added a task: T11620: Port from KSslError to QSslError.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24590

To: vkrause, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24590: Port KSslErrorUiData to QSslError

2019-10-12 Thread Volker Krause 
vkrause created this revision.
vkrause added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24590

AFFECTED FILES
  src/core/ksslerroruidata.cpp
  src/core/ksslerroruidata_p.h
  src/widgets/sslui.cpp

To: vkrause, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns