D24593: Modified breeze shadows

2019-10-12 Thread Niccolò Venerandi 
niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24593

To: niccolove
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24593: Modified breeze shadows

2019-10-12 Thread Niccolò Venerandi 
niccolove created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
niccolove requested review of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  breeze-shadows (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24593

AFFECTED FILES
  src/desktoptheme/breeze/dialogs/background.svg
  src/desktoptheme/breeze/widgets/panel-background.svg

To: niccolove
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24593: Modified breeze shadows

2019-10-12 Thread Niccolò Venerandi 
niccolove added a reviewer: VDG.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24593

To: niccolove, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24593: Modified breeze shadows

2019-10-12 Thread Niccolò Venerandi 
niccolove added a comment.


  Uhm, I probably got Scour wrong. Sorry.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24593

To: niccolove, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24593: Modified breeze shadows

2019-10-12 Thread David Edmundson 
davidedmundson added a comment.


  Please write what you've changed and why

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24593

To: niccolove, #vdg
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D24593: Modified breeze shadows

2019-10-12 Thread Niccolò Venerandi 
niccolove edited the summary of this revision.
niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24593

To: niccolove, #vdg
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D24593: Modified breeze shadows

2019-10-12 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 67790.
niccolove added a comment.


  Used scour on svg files

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24593?vs=67789&id=67790

BRANCH
  breeze-shadows (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24593

AFFECTED FILES
  src/desktoptheme/breeze/dialogs/background.svg
  src/desktoptheme/breeze/widgets/panel-background.svg

To: niccolove, #vdg
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D24593: Modified breeze shadows

2019-10-12 Thread Niccolò Venerandi 
niccolove added a comment.


  I'm sorry, when I use scour on svg files, it looks like git does not 
recognize that the file has changed. How can I fix that?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24593

To: niccolove, #vdg
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D24593: Modified breeze shadows

2019-10-12 Thread Nathaniel Graham 
ngraham added a comment.


  In D24593#546042 , @niccolove 
wrote:
  
  > I'm sorry, when I use scour on svg files, it looks like git does not 
recognize that the file has changed. How can I fix that?
  
  
  That means that the files actually haven't changed compared to the prior 
version. It looks like the diff is messed up and is using the scoured version 
as the base rather than the latest git master.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24593

To: niccolove, #vdg
Cc: ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24593: Modified breeze shadows

2019-10-13 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 67852.
niccolove added a comment.


  Re-done the dialogs/background.svg

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24593?vs=67790&id=67852

BRANCH
  breeze-shadows (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24593

AFFECTED FILES
  src/desktoptheme/breeze/dialogs/background.svg
  src/desktoptheme/breeze/widgets/panel-background.svg

To: niccolove, #vdg
Cc: ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24593: Modified breeze shadows

2019-10-13 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 67853.
niccolove added a comment.


  Re-done the widgets/panel-background.svg

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24593?vs=67852&id=67853

BRANCH
  breeze-shadows (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24593

AFFECTED FILES
  src/desktoptheme/breeze/dialogs/background.svg
  src/desktoptheme/breeze/widgets/panel-background.svg

To: niccolove, #vdg
Cc: ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24593: Modified breeze shadows

2019-10-13 Thread Niccolò Venerandi 
niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24593

To: niccolove, #vdg
Cc: ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24593: Modified breeze shadows

2019-10-13 Thread Niccolò Venerandi 
niccolove added a comment.


  In D24593#546309 , @ngraham wrote:
  
  > In D24593#546042 , @niccolove 
wrote:
  >
  > > I'm sorry, when I use scour on svg files, it looks like git does not 
recognize that the file has changed. How can I fix that?
  >
  >
  > That means that the files actually haven't changed compared to the prior 
version. It looks like the diff is messed up and is using the scoured version 
as the base rather than the latest git master.
  
  
  It now shows me a diff, is relatively to master or to my previous svg? in 
that case, I can do another diff  without messing up 
(hopefully)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24593

To: niccolove, #vdg
Cc: ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24593: Modified breeze shadows

2019-10-13 Thread Filip Fila 
filipf added a comment.


  > b) radial gradients instead of linear on the four sides to make the center 
darker than the angles.
  
  Other than this, they look great to me. I think they should be uniformly 
dispersed.
  
  One of the things with shadows is that the user shouldn't really notice them. 
With the radial style I can't help but notice there's shadows missing in the 
corners.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24593

To: niccolove, #vdg
Cc: filipf, ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D24593: Modified breeze shadows

2019-10-13 Thread Lucas Andrade 
Luwx added a comment.


  Making good looking pure svg box shadows is a bit tricky.
  
  A while back I tried to create one:
  
  F7590931: shadow.png 
  
  The right one uses blur (like breeze decoration does) and the left uses 
gradients with quite a few stops to emulate the blurred square (I don't know if 
this has any effect on performance), radial gradients were used only in the 
corners.
  
  It this is of any help, here is the svg: F7590940: shadow.svg 


REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24593

To: niccolove, #vdg
Cc: Luwx, filipf, ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, bruns

D24593: Modified breeze shadows

2019-10-15 Thread Niccolò Venerandi 
niccolove added a comment.


  In D24593#546586 , @filipf wrote:
  
  > > b) radial gradients instead of linear on the four sides to make the 
center darker than the angles.
  >
  > Other than this, they look great to me. I think they should be uniformly 
dispersed.
  >
  > One of the things with shadows is that the user shouldn't really notice 
them. With the radial style I can't help but notice there's shadows missing in 
the corners.
  
  
  What do you think?
  F7601293: Screenshot_20191015_190157.png 

  
  In D24593#546731 , @Luwx wrote:
  
  > Making good looking pure svg box shadows is a bit tricky.
  >
  > A while back I tried to create one:
  >
  > F7590931: shadow.png 
  >
  > The left one uses blur (like breeze decoration does) and the right uses 
gradients with quite a few stops to emulate the blurred square (I don't know if 
this has any effect on performance), radial gradients were used only in the 
corners.
  >
  > It this is of any help, here is the svg: F7590940: shadow.svg 

  
  
  Thanks, that's interesting. May I ask why did you use multiple linear 
gradients instead of a big linear one?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24593

To: niccolove, #vdg
Cc: Luwx, filipf, ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, bruns

D24593: Modified breeze shadows

2019-10-19 Thread Niccolò Venerandi 
niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24593

To: niccolove, #vdg
Cc: Luwx, filipf, ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, bruns

D24593: Modified breeze shadows

2019-10-21 Thread Nathaniel Graham 
ngraham added a comment.


  Is this ready for formal review now or are you still tweaking and/or 
soliciting comments?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24593

To: niccolove, #vdg
Cc: Luwx, filipf, ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, bruns

D24593: Modified breeze shadows

2019-10-24 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 68626.
niccolove added a comment.


  Made missing shadow on corners less noticeable on widgets shadows

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24593?vs=67853&id=68626

BRANCH
  breeze-shadows (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24593

AFFECTED FILES
  src/desktoptheme/breeze/dialogs/background.svg
  src/desktoptheme/breeze/widgets/panel-background.svg

To: niccolove, #vdg
Cc: Luwx, filipf, ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, bruns

D24593: Modified breeze shadows

2019-10-24 Thread Niccolò Venerandi 
niccolove added a comment.


  In D24593#551591 , @ngraham wrote:
  
  > Is this ready for formal review now or are you still tweaking and/or 
soliciting comments?
  
  
  Ready for review :-)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24593

To: niccolove, #vdg
Cc: Luwx, filipf, ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, bruns

D24593: Modified breeze shadows

2019-10-24 Thread Nathaniel Graham 
ngraham added a comment.


  Needs a rebase on master. It doesn't apply for me.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24593

To: niccolove, #vdg
Cc: Luwx, filipf, ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, bruns

D24593: Modified breeze shadows

2019-10-26 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 68788.
niccolove added a comment.


  Rebase on master - test

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24593?vs=68626&id=68788

BRANCH
  breeze-shadows (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24593

AFFECTED FILES
  src/desktoptheme/breeze/dialogs/background.svg
  src/desktoptheme/breeze/widgets/panel-background.svg

To: niccolove, #vdg
Cc: Luwx, filipf, ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, bruns

D24593: Modified breeze shadows

2019-10-26 Thread Niccolò Venerandi 
niccolove added a comment.


  In D24593#552915 , @ngraham wrote:
  
  > Needs a rebase on master. It doesn't apply for me.
  
  
  Does it apply now? If not, I messed up something and I will just reset to 
master and add the svgs again.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24593

To: niccolove, #vdg
Cc: Luwx, filipf, ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, bruns

D24593: Modified breeze shadows

2019-10-26 Thread Nathaniel Graham 
ngraham added a comment.


  Still not working, sorry.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24593

To: niccolove, #vdg
Cc: Luwx, filipf, ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, bruns

D24593: Modified breeze shadows

2019-10-28 Thread Niccolò Venerandi 
niccolove abandoned this revision.
niccolove added a comment.


  Let's try again https://phabricator.kde.org/D25015

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24593

To: niccolove, #vdg
Cc: Luwx, filipf, ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, bruns