D24608: Use ECMGenerateExportHeader to manage deprecated API better
kossebau created this revision. kossebau added reviewers: Frameworks, cfeck. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Allows - projects linking to KIconThemes to hide deprecated API up to a given version or silence deprecation warnings after a given version, using - -DKICONTHEMES_DISABLE_DEPRECATED_BEFORE_AND_AT - -DKICONTHEMES_NO_DEPRECATED - -DKICONTHEMES_DEPRECATED_WARNINGS_SINCE - -DKICONTHEMES_NO_DEPRECATED_WARNINGS or - -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT - -DKF_NO_DEPRECATED - -DKF_DEPRECATED_WARNINGS_SINCE - -DKF_NO_DEPRECATED_WARNINGS - to build KIconThemes optionally with deprecated API excluded from the build, using "EXCLUDE_DEPRECATED_BEFORE_AND_AT" cmake argument. TEST PLAN Builds with EXCLUDE_DEPRECATED_BEFORE_AND_AT set to 0, 4.8.0, 5.0.0, 5.63.0, CURRENT. REPOSITORY R302 KIconThemes BRANCH useECMGenerateExportHeader REVISION DETAIL https://phabricator.kde.org/D24608 AFFECTED FILES CMakeLists.txt src/CMakeLists.txt src/kiconloader.cpp src/kiconloader.h src/kicontheme.cpp To: kossebau, #frameworks, cfeck Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D24608: Use ECMGenerateExportHeader to manage deprecated API better
mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. Seems ok for me REPOSITORY R302 KIconThemes BRANCH useECMGenerateExportHeader REVISION DETAIL https://phabricator.kde.org/D24608 To: kossebau, #frameworks, cfeck, mlaurent Cc: mlaurent, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D24608: Use ECMGenerateExportHeader to manage deprecated API better
This revision was automatically updated to reflect the committed changes. Closed by commit R302:f046410b316f: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24608?vs=67843&id=68167#toc REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24608?vs=67843&id=68167 REVISION DETAIL https://phabricator.kde.org/D24608 AFFECTED FILES CMakeLists.txt src/CMakeLists.txt src/kiconloader.cpp src/kiconloader.h src/kicontheme.cpp To: kossebau, #frameworks, cfeck, mlaurent Cc: mlaurent, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
