D24650: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-18 Thread Friedrich W. H. Kossebau 
This revision was automatically updated to reflect the committed changes.
Closed by commit R235:f79367c1aff3: Use ECMGenerateExportHeader to manage 
deprecated API better (authored by kossebau).

REPOSITORY
  R235 Attica

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24650?vs=67936=68244

REVISION DETAIL
  https://phabricator.kde.org/D24650

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/downloaddescription.cpp
  src/downloaddescription.h
  src/provider.cpp
  src/provider.h
  src/providermanager.cpp
  src/providermanager.h

To: kossebau, #frameworks, gladhorn, leinir, mlaurent
Cc: mlaurent, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24650: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-18 Thread Dan Leinir Turthra Jensen 
leinir accepted this revision.
leinir added a comment.


  Very nicely, go for it :)

REPOSITORY
  R235 Attica

BRANCH
  useECMGenerateExportHeader

REVISION DETAIL
  https://phabricator.kde.org/D24650

To: kossebau, #frameworks, gladhorn, leinir, mlaurent
Cc: mlaurent, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24650: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-17 Thread Laurent Montel 
mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.


  Seems ok for me

REPOSITORY
  R235 Attica

BRANCH
  useECMGenerateExportHeader

REVISION DETAIL
  https://phabricator.kde.org/D24650

To: kossebau, #frameworks, gladhorn, leinir, mlaurent
Cc: mlaurent, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24650: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-14 Thread Friedrich W. H. Kossebau 
kossebau created this revision.
kossebau added reviewers: Frameworks, gladhorn, leinir.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Allows
  
  - projects linking to Attica to hide deprecated API up to a given version or 
silence deprecation warnings after a given version, using
- -DATTICA_DISABLE_DEPRECATED_BEFORE_AND_AT
- -DATTICA_NO_DEPRECATED
- -DATTICA_DEPRECATED_WARNINGS_SINCE
- -DATTICA_NO_DEPRECATED_WARNINGS
  
  or
- -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT
- -DKF_NO_DEPRECATED
- -DKF_DEPRECATED_WARNINGS_SINCE
- -DKF_NO_DEPRECATED_WARNINGS
  - to build Attica optionally with deprecated API excluded from the build, 
using "EXCLUDE_DEPRECATED_BEFORE_AND_AT" cmake argument.

TEST PLAN
  Builds with EXCLUDE_DEPRECATED_BEFORE_AND_AT set to 0, 0.2.0, 5.4.0,
  5.23.0, CURRENT.

REPOSITORY
  R235 Attica

BRANCH
  useECMGenerateExportHeader

REVISION DETAIL
  https://phabricator.kde.org/D24650

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/downloaddescription.cpp
  src/downloaddescription.h
  src/provider.cpp
  src/provider.h
  src/providermanager.cpp
  src/providermanager.h

To: kossebau, #frameworks, gladhorn, leinir
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns