D24686: Replace usage of deprecated SlaveBase::config() by SlaveBase::configValue

[Méven Car]

meven created this revision.
meven added a reviewer: dfaure.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  With D23523  and D24582 
, we can avoid some IO by not using 
SlaveBase::config()
  
  Will wait for KF 5.64 release before landing.

TEST PLAN
  Compiles

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24686

AFFECTED FILES
  CMakeLists.txt
  nfs/nfsv2.cpp
  nfs/nfsv3.cpp
  sftp/kio_sftp.cpp
  smb/kio_smb_dir.cpp

To: meven, dfaure
Cc: kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, 
fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D24686: Replace usage of deprecated SlaveBase::config() by SlaveBase::configValue

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  I never know when it's OK to increase the KF5 version dependency from 
applications modules, though.
  
  I have a ton of pending patches (to port away from KWindowSystem deprecated 
API) which require a KF5 version dep upgrade too...

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24686

To: meven, dfaure
Cc: kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, 
fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D24686: Replace usage of deprecated SlaveBase::config() by SlaveBase::configValue

[Elvis Angelaccio]

elvisangelaccio added a comment.


  In D24686#550533 , @dfaure wrote:
  
  > I never know when it's OK to increase the KF5 version dependency from 
applications modules, though.
  >
  > I have a ton of pending patches (to port away from KWindowSystem deprecated 
API) which require a KF5 version dep upgrade too...
  
  
  It's always ok to bump the KF5 version as long as you do it before the 
dependency freeze day set by the release team.

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24686

To: meven, dfaure
Cc: elvisangelaccio, kde-frameworks-devel, kfm-devel, iasensio, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D24686: Replace usage of deprecated SlaveBase::config() by SlaveBase::configValue

[David Faure]

dfaure added a comment.


  Thanks for the information.
  
  https://community.kde.org/Schedules doesn't have a 19.12 schedule so I guess 
there's no freeze yet :-)

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24686

To: meven, dfaure
Cc: elvisangelaccio, kde-frameworks-devel, kfm-devel, iasensio, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D24686: Replace usage of deprecated SlaveBase::config() by SlaveBase::configValue

[Méven Car]

meven added a comment.


  In D24686#550567 , 
@elvisangelaccio wrote:
  
  > It's always ok to bump the KF5 version as long as you do it before the 
dependency freeze day set by the release team.
  
  
  So I guess it is the case here : Apps 19.12 is still in a few months, we can 
bump KF5 deps I think.

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24686

To: meven, dfaure
Cc: elvisangelaccio, kde-frameworks-devel, kfm-devel, iasensio, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D24686: Replace usage of deprecated SlaveBase::config() by SlaveBase::configValue

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:49440c0cbea1: Replace usage of deprecated 
SlaveBase::config() by SlaveBase::configValue (authored by meven).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24686?vs=68023&id=69592

REVISION DETAIL
  https://phabricator.kde.org/D24686

AFFECTED FILES
  CMakeLists.txt
  nfs/nfsv2.cpp
  nfs/nfsv3.cpp
  sftp/kio_sftp.cpp
  smb/kio_smb_dir.cpp

To: meven, dfaure
Cc: elvisangelaccio, kde-frameworks-devel, kfm-devel, pberestov, iasensio, 
fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov