D24841: Use modern way to set the C/CXX standard

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D24841#552842 , @vonreth wrote:
  
  > Where are those tests running? I'm only aware of 
https://build.kde.org/job/Frameworks/job/extra-cmake-modules/
  
  
  The tests are currntly sadly skipped on CI, compare T11858 

  
  Someone(tm) needs to act on this, myself had no time yet.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24841

To: vonreth, dfaure, cullmann
Cc: kossebau, cgiboudeaux, aacid, chehrlic, kde-frameworks-devel, 
kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D24841: Use modern way to set the C/CXX standard

[Hannah von Reth]

vonreth added a comment.


  In D24841#552600 , @cgiboudeaux 
wrote:
  
  > Another issue caused by the new CMake 3.5 dependency, some tests fail:
  >
  > > 
  > > 
  > >   59 - ecm_setup_version-old_simple (Failed)
  > >   60 - ecm_setup_version-old_soversion (Failed)
  > >   61 - ecm_setup_version-old_version_file (Failed)
  > >   62 - ecm_setup_version-old_version_file_abspath (Failed)
  > >   63 - ecm_setup_version-old_version_file_anynewer (Failed)
  > >   64 - ecm_setup_version-old_version_file_exact (Failed)
  > >   65 - ecm_setup_version-old_version_file_samemajor (Failed)
  > >   66 - ecm_setup_version-old_header (Failed)
  > >   67 - ecm_setup_version-old_header_abspath (Failed)
  >
  > (+2 others not related to the recent changes)
  >  I didn't look yet at the details. My guess is the CMake policy changes 
between 2.8.12 and 3.5
  
  
  Where are those tests running? I'm only aware of 
https://build.kde.org/job/Frameworks/job/extra-cmake-modules/

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24841

To: vonreth, dfaure, cullmann
Cc: cgiboudeaux, aacid, chehrlic, kde-frameworks-devel, kde-buildsystem, 
LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D24841: Use modern way to set the C/CXX standard

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  Another issue caused by the new CMake 3.5 dependency, some tests fail:
  
  > 
  > 
  >   59 - ecm_setup_version-old_simple (Failed)
  >   60 - ecm_setup_version-old_soversion (Failed)
  >   61 - ecm_setup_version-old_version_file (Failed)
  >   62 - ecm_setup_version-old_version_file_abspath (Failed)
  >   63 - ecm_setup_version-old_version_file_anynewer (Failed)
  >   64 - ecm_setup_version-old_version_file_exact (Failed)
  >   65 - ecm_setup_version-old_version_file_samemajor (Failed)
  >   66 - ecm_setup_version-old_header (Failed)
  >   67 - ecm_setup_version-old_header_abspath (Failed)
  
  (+2 others not related to the recent changes)
  I didn't look yet at the details. My guess is the CMake policy changes 
between 2.8.12 and 3.5

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24841

To: vonreth, dfaure, cullmann
Cc: cgiboudeaux, aacid, chehrlic, kde-frameworks-devel, kde-buildsystem, 
LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D24841: Use modern way to set the C/CXX standard

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  In D24841#552577 , @dfaure wrote:
  
  > Where did -std=gnu++14 come from? The old code above certainly didn't set 
it.
  >
  > Maybe some projects were doing `set(CMAKE_CXX_STANDARD 14)` before 
including KDECompilerSettings? We could test the var here to avoid overwriting 
it...
  
  
  Yes, the CXX standard is set before looking for ECM in both repositories.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24841

To: vonreth, dfaure, cullmann
Cc: cgiboudeaux, aacid, chehrlic, kde-frameworks-devel, kde-buildsystem, 
LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D24841: Use modern way to set the C/CXX standard

[David Faure]

dfaure added a comment.


  Where did -std=gnu++14 come from? The old code above certainly didn't set it.
  
  Maybe some projects were doing `set(CMAKE_CXX_STANDARD 14)` before including 
KDECompilerSettings? We could test the var here to avoid overwriting it...

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24841

To: vonreth, dfaure, cullmann
Cc: cgiboudeaux, aacid, chehrlic, kde-frameworks-devel, kde-buildsystem, 
LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D24841: Use modern way to set the C/CXX standard

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  I'm seeing build failures in several repositories seemingly caused by 6e3c794 
 (eg 
akonadi, kasync)
  
  Building with clang9, before:
  `-std=c++0x -std=gnu++14` are set
  
  After:
  `-std=gnu++11`
  
  and the build fails with c++14 features such as `make_unique`

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24841

To: vonreth, dfaure, cullmann
Cc: cgiboudeaux, aacid, chehrlic, kde-frameworks-devel, kde-buildsystem, 
LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D24841: Use modern way to set the C/CXX standard

[Hannah von Reth]

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:6e3c794e7c63: Use modern way to set the C/CXX standad 
(authored by vonreth).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D24841?vs=68488=68560#toc

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24841?vs=68488=68560

REVISION DETAIL
  https://phabricator.kde.org/D24841

AFFECTED FILES
  kde-modules/KDECompilerSettings.cmake

To: vonreth, dfaure, cullmann
Cc: aacid, chehrlic, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns

D24841: Use modern way to set the C/CXX standard

[Christophe Giboudeaux]

cgiboudeaux retitled this revision from "Use modern way to set the C/CXX 
standad" to "Use modern way to set the C/CXX standard".
cgiboudeaux edited the summary of this revision.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  cmake_c_standard

REVISION DETAIL
  https://phabricator.kde.org/D24841

To: vonreth, dfaure, cullmann
Cc: aacid, chehrlic, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns