D24971: KCoreAddons: make programIconName() available to KConfigWidgets and KXmlGui

2019-10-26 Thread David Faure 
dfaure created this revision.
dfaure added a reviewer: kossebau.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  NO_CHANGELOG

TEST PLAN
  Builds, and allows to build kconfigwidgets

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24971

AFFECTED FILES
  CMakeLists.txt
  src/lib/kaboutdata.h

To: dfaure, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24971: KCoreAddons: make programIconName() available to KConfigWidgets and KXmlGui

2019-10-26 Thread Friedrich W. H. Kossebau 
kossebau added inline comments.

INLINE COMMENTS

> kaboutdata.h:944
>  
> -#if KCOREADDONS_ENABLE_DEPRECATED_SINCE(5, 2)
> +#if KCOREADDONS_BUILD_DEPRECATED_SINCE(5, 2)
>  /**

Possibly best to document why only BUILD, pointing out infrastructure code 
supporting legacy code needs to always see this, unless disabled from build 
explicitly.
To avoid the next person thinking this was a mistake and changing to ENABLE 
again.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D24971

To: dfaure, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24971: KCoreAddons: make programIconName() available to KConfigWidgets and KXmlGui

2019-10-26 Thread Friedrich W. H. Kossebau 
kossebau added inline comments.

INLINE COMMENTS

> CMakeLists.txt:96
>  add_definitions(-DQT_DEPRECATED_WARNINGS_SINCE=0x06)
> +add_definitions(-DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x053f00)
>  add_definitions(-DQT_NO_FOREACH)

Given KCOreAddons does not link against other KF modules, this does not make 
sense here.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D24971

To: dfaure, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24971: KCoreAddons: make programIconName() available to KConfigWidgets and KXmlGui

2019-10-26 Thread David Faure 
dfaure updated this revision to Diff 68798.
dfaure added a comment.


  Revert change to CMakeLists.txt; explain change as comment

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24971?vs=68796&id=68798

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24971

AFFECTED FILES
  src/lib/kaboutdata.h

To: dfaure, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24971: KCoreAddons: make programIconName() available to KConfigWidgets and KXmlGui

2019-10-26 Thread Friedrich W. H. Kossebau 
kossebau accepted this revision.
kossebau added a comment.
This revision is now accepted and ready to land.


  Good with me.

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24971

To: dfaure, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24971: KCoreAddons: make programIconName() available to KConfigWidgets and KXmlGui

2019-10-26 Thread David Faure 
dfaure closed this revision.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D24971

To: dfaure, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns