D24981: Modelines: fix end of comment

2019-10-28 Thread Nibaldo González
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:73489a79f9fd: Modelines: fix end of comment (authored by 
nibags).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24981?vs=68820=68870

REVISION DETAIL
  https://phabricator.kde.org/D24981

AFFECTED FILES
  autotests/folding/test.js.fold
  autotests/html/test.js.html
  autotests/input/test.js
  autotests/reference/test.js.ref
  data/syntax/modelines.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann


D24981: Modelines: fix end of comment

2019-10-27 Thread Dominik Haumann
dhaumann accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix-end-modelines

REVISION DETAIL
  https://phabricator.kde.org/D24981

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann


D24981: Modelines: fix end of comment

2019-10-27 Thread Nibaldo González
nibags created this revision.
nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  Use `fallthroughContext` to finish Modeline. This allows you to finish the 
comment block correctly if the Modeline is incomplete.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix-end-modelines

REVISION DETAIL
  https://phabricator.kde.org/D24981

AFFECTED FILES
  autotests/folding/test.js.fold
  autotests/html/test.js.html
  autotests/input/test.js
  autotests/reference/test.js.ref
  data/syntax/modelines.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann