D24990: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings

2019-11-28 Thread Friedrich W. H. Kossebau 
kossebau added a comment.


  In D24990#564667 , @kossebau wrote:
  
  > Hm, only noticed now that this actually has an unwanted sideeffects: it 
triggers deprecation warnings for all deprecated warning also inside each 
library itself. Which is not what one wants.
  
  
  D25589  is now up as proposal to fix that.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24990

To: kossebau, #frameworks, #build_system, apol, dfaure
Cc: dfaure, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D24990: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings

2019-11-19 Thread Friedrich W. H. Kossebau 
kossebau added a comment.


  In D24990#564670 , @dfaure wrote:
  
  > So we need to set FOO_DISABLE_DEPRECATED_BEFORE_AND_AT to N-1 while 
building FOO itself, right? Either magically here, or manually in every 
module...
  
  
  Nono, FOO_DISABLE_DEPRECATED_BEFORE_AND_AT does not need to be touched, that 
works fine.
  We want to rather have a new sane automatism for sane values of 
FOO_DEPRECATED_WARNINGS_SINCE in the build of FOO, despite group variables 
being set. While also still allowing full flexibility to other non-KF usage 
patterns.
  I have a small set of approaches drafted/tested so far, but need to explore 
them in full details yet for all KDE & non-KDE usages I know about (& imagine). 
Just mentioning here that I am cooking up something :)

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24990

To: kossebau, #frameworks, #build_system, apol, dfaure
Cc: dfaure, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D24990: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings

2019-11-19 Thread David Faure 
dfaure added a comment.


  So we need to set FOO_DISABLE_DEPRECATED_BEFORE_AND_AT to N-1 while building 
FOO itself, right? Either magically here, or manually in every module...

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24990

To: kossebau, #frameworks, #build_system, apol, dfaure
Cc: dfaure, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D24990: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings

2019-11-19 Thread Friedrich W. H. Kossebau 
kossebau added a comment.


  Hm, only noticed now that this actually has an unwanted sideeffects: it 
triggers deprecation warnings for all deprecated warning also inside each 
library itself. Which is not what one wants.
  
  Because so far FOO_DISABLE_DEPRECATED_BEFORE_AND_AT as set while building 
library FOO defaults FOO_DEPRECATED_WARNINGS_SINCE to the same version, which 
means, any calls of own deprecated API will be without warnings as well as also 
with the autotests (due to definitions being exported in the BUILD interface). 
But with the group variant of *_DEPRECATED_WARNINGS_SINCE now being set, 
FOO_DEPRECATED_WARNINGS_SINCE instead defaults to that value.
  
  Reserved some time this week to give this some more thought, so far no 
satisfying proposal yet developed.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24990

To: kossebau, #frameworks, #build_system, apol, dfaure
Cc: dfaure, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D24990: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings

2019-11-03 Thread Friedrich W. H. Kossebau 
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:879769daf047: KDEFrameworkCompilerSettings: enable all Qt 
% KF deprecation warnings (authored by kossebau).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24990?vs=68847&id=69235

REVISION DETAIL
  https://phabricator.kde.org/D24990

AFFECTED FILES
  kde-modules/KDEFrameworkCompilerSettings.cmake

To: kossebau, #frameworks, #build_system, apol, dfaure
Cc: dfaure, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D24990: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings

2019-11-03 Thread Friedrich W. H. Kossebau 
kossebau added a comment.


  Merci, will land later tonight. Bonnes vacances :)

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  enableallqtkfdeprecationwarningsforframeworks

REVISION DETAIL
  https://phabricator.kde.org/D24990

To: kossebau, #frameworks, #build_system, apol, dfaure
Cc: dfaure, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D24990: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings

2019-11-03 Thread David Faure 
dfaure accepted this revision.
dfaure added a comment.


  Done (in the process of being pushed), you can push this.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  enableallqtkfdeprecationwarningsforframeworks

REVISION DETAIL
  https://phabricator.kde.org/D24990

To: kossebau, #frameworks, #build_system, apol, dfaure
Cc: dfaure, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D24990: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings

2019-11-03 Thread Friedrich W. H. Kossebau 
kossebau added a subscriber: dfaure.
kossebau added a comment.


  @dfaure Hi. Any chance you  you can sneak in before you are away (enjoy :) ) 
to remove the "-DQT_DEPRECATED_WARNINGS_SINCE=0x06" from all the KF modules 
in the next days? Otherwise would land this here with just the 
-DKF_DEPRECATED_WARNINGS_SINCE=0x06 for now, otherwise people do not see 
warnings in KF modules when they should.
  
  I sadly have no setup for easy mass removal of 
"-DQT_DEPRECATED_WARNINGS_SINCE=0x06" from all KF modules,otherwise I would 
have done that
  
  Cmp. also 
https://mail.kde.org/pipermail/kde-frameworks-devel/2019-October/096307.html

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  enableallqtkfdeprecationwarningsforframeworks

REVISION DETAIL
  https://phabricator.kde.org/D24990

To: kossebau, #frameworks, #build_system, apol
Cc: dfaure, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D24990: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings

2019-10-28 Thread Aleix Pol Gonzalez 
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  enableallqtkfdeprecationwarningsforframeworks

REVISION DETAIL
  https://phabricator.kde.org/D24990

To: kossebau, #frameworks, #build_system, apol
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D24990: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings

2019-10-27 Thread Friedrich W. H. Kossebau 
kossebau created this revision.
kossebau added reviewers: Frameworks, Build System.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
kossebau requested review of this revision.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  enableallqtkfdeprecationwarningsforframeworks

REVISION DETAIL
  https://phabricator.kde.org/D24990

AFFECTED FILES
  kde-modules/KDEFrameworkCompilerSettings.cmake

To: kossebau, #frameworks, #build_system
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns