D25184: Define property X-Plasma-MainScript for Plasma/Wallpaper

2019-11-07 Thread Vlad Zahorodnii 
zzag abandoned this revision.
zzag added a comment.


  Okay, I see.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25184

To: zzag, #plasma
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25184: Define property X-Plasma-MainScript for Plasma/Wallpaper

2019-11-07 Thread David Edmundson 
davidedmundson added a comment.


  From wallpaper interface:
  
m_qmlObject->setSource(m_pkg.fileUrl("mainscript"));
  
  packages.cpp
  void QmlWallpaperPackage::initPackage(Plasma::Package *package)
  {
  
package->addFileDefinition("mainscript", QStringLiteral("ui/main.qml"), 
i18n("Main Script File"));
package->setRequired("mainscript", true);
  
  it seems hardcoded in p-f, at which point the warning itself is correct and 
it's the wallpapers themselves that are wrong.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25184

To: zzag, #plasma
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25184: Define property X-Plasma-MainScript for Plasma/Wallpaper

2019-11-06 Thread Vlad Zahorodnii 
zzag retitled this revision from "Add property definition for 
"X-Plasma-MainScript" for Plasma/Wallpaper" to "Define property 
X-Plasma-MainScript for Plasma/Wallpaper".

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25184

To: zzag, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns