D25215: Fix a couple of broken links

2019-11-08 Thread Méven Car 
meven created this revision.
meven added a reviewer: leinir.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REPOSITORY
  R304 KNewStuff

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25215

AFFECTED FILES
  src/kmoretools/kmoretoolspresets.cpp

To: meven, leinir
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25215: Fix a couple of broken links

2019-11-08 Thread Dan Leinir Turthra Jensen 
leinir accepted this revision.
leinir added a comment.
This revision is now accepted and ready to land.


  Good catch :)

REPOSITORY
  R304 KNewStuff

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25215

To: meven, leinir
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25215: Fix a couple of broken links

2019-11-08 Thread Nathaniel Graham 
ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  We should use the kde.org/applications links, e.g. 
https://kde.org/applications/system/org.kde.kdf, not 
https://utils.kde.org/projects/kdf

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D25215

To: meven, leinir, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25215: Fix a couple of broken links

2019-11-08 Thread Méven Car 
meven added a comment.


  In D25215#560047 , @ngraham wrote:
  
  > We should use the kde.org/applications links, e.g. 
https://kde.org/applications/system/org.kde.kdf, not 
https://utils.kde.org/projects/kdf
  
  
  I did not find this url, thanks

INLINE COMMENTS

> kmoretoolspresets.cpp:83
>  ADD_ENTRY(QStringLiteral("org.kde.kcharselect"),0, 
> "https://utils.kde.org/projects/kcharselect/";, 
> QStringLiteral("org.kde.kcharselect"));
> -ADD_ENTRY(QStringLiteral("org.kde.kdf"),0, 
> "https://www.kde.org/applications/system/kdiskfree";, 
> QStringLiteral("org.kde.kdf"));
> +ADD_ENTRY(QStringLiteral("org.kde.kdf"),0, 
> "https://utils.kde.org/projects/kdf";, QStringLiteral("org.kde.kdf"));
>  ADD_ENTRY(QStringLiteral("org.kde.kfind"),  1, 
> "https://www.kde.org/applications/utilities/kfind/";, 
> QStringLiteral("org.kde.kfind.desktop")); // has good filtering options

Replace with https://kde.org/applications/system/org.kde.kdf

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D25215

To: meven, leinir, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25215: Fix a couple of broken links

2019-11-08 Thread Méven Car 
meven updated this revision to Diff 69456.
meven added a comment.


  Fix kdf link and update others

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25215?vs=69447&id=69456

BRANCH
  arcpatch-D25215

REVISION DETAIL
  https://phabricator.kde.org/D25215

AFFECTED FILES
  src/kmoretools/kmoretoolspresets.cpp

To: meven, leinir, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25215: Fix a couple of broken links, update links to https://kde.org/applications/

2019-11-08 Thread Méven Car 
meven retitled this revision from "Fix a couple of broken links" to "Fix a 
couple of broken links, update links to https://kde.org/applications/";.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D25215

To: meven, leinir, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25215: Fix a couple of broken links, update links to https://kde.org/applications/

2019-11-08 Thread Méven Car 
meven updated this revision to Diff 69457.
meven marked an inline comment as done.
meven added a comment.


  amend comment

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25215?vs=69456&id=69457

BRANCH
  arcpatch-D25215

REVISION DETAIL
  https://phabricator.kde.org/D25215

AFFECTED FILES
  src/kmoretools/kmoretoolspresets.cpp

To: meven, leinir, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25215: Fix a couple of broken links, update links to https://kde.org/applications/

2019-11-08 Thread Méven Car 
meven updated this revision to Diff 69460.
meven added a comment.


  Replace remaning kde project links to https://kde.org/applications/

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25215?vs=69457&id=69460

BRANCH
  arcpatch-D25215

REVISION DETAIL
  https://phabricator.kde.org/D25215

AFFECTED FILES
  src/kmoretools/kmoretoolspresets.cpp

To: meven, leinir, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25215: Fix a couple of broken links, update links to https://kde.org/applications/

2019-11-08 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  While you're touching this stuff, it'll probably be easy to implement 
https://bugs.kde.org/show_bug.cgi?id=412320

REPOSITORY
  R304 KNewStuff

BRANCH
  arcpatch-D25215

REVISION DETAIL
  https://phabricator.kde.org/D25215

To: meven, leinir, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25215: Fix a couple of broken links, update links to https://kde.org/applications/

2019-11-08 Thread Méven Car 
meven edited the summary of this revision.

REPOSITORY
  R304 KNewStuff

BRANCH
  arcpatch-D25215

REVISION DETAIL
  https://phabricator.kde.org/D25215

To: meven, leinir, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25215: Fix a couple of broken links, update links to https://kde.org/applications/

2019-11-08 Thread Méven Car 
meven retitled this revision from "Fix a couple of broken links, update links 
to https://kde.org/applications/, add obs" to "Fix a couple of broken links, 
update links to https://kde.org/applications/";.

REPOSITORY
  R304 KNewStuff

BRANCH
  arcpatch-D25215

REVISION DETAIL
  https://phabricator.kde.org/D25215

To: meven, leinir, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25215: Fix a couple of broken links, update links to https://kde.org/applications/

2019-11-08 Thread Méven Car 
meven updated this revision to Diff 69477.
meven added a comment.


  Split obs changes to D25221 

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25215?vs=69474&id=69477

BRANCH
  arcpatch-D25215

REVISION DETAIL
  https://phabricator.kde.org/D25215

AFFECTED FILES
  src/kmoretools/kmoretoolspresets.cpp

To: meven, leinir, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25215: Fix a couple of broken links, update links to https://kde.org/applications/

2019-11-08 Thread Méven Car 
meven added a comment.


  In D25215#560229 , @ngraham wrote:
  
  > In an ideal world the OBS stuff would be in a separate patch. :)
  
  
  Done.
  
  I interpreted "While you're touching this stuff" wrongly.

REPOSITORY
  R304 KNewStuff

BRANCH
  arcpatch-D25215

REVISION DETAIL
  https://phabricator.kde.org/D25215

To: meven, leinir, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25215: Fix a couple of broken links, update links to https://kde.org/applications/

2019-11-08 Thread Méven Car 
This revision was automatically updated to reflect the committed changes.
Closed by commit R304:cdafed6b395f: Fix a couple of broken links, update links 
to https://kde.org/applications/ (authored by meven).

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25215?vs=69477&id=69480

REVISION DETAIL
  https://phabricator.kde.org/D25215

AFFECTED FILES
  src/kmoretools/kmoretoolspresets.cpp

To: meven, leinir, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25215: Fix a couple of broken links, update links to https://kde.org/applications/

2019-11-08 Thread Nathaniel Graham 
ngraham added a comment.


  No problem, I wasn't being very clear myself. :)

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D25215

To: meven, leinir, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25215: Fix a couple of broken links, update links to https://kde.org/applications/

2019-11-09 Thread Albert Astals Cid 
aacid added subscribers: jriddell, aacid.
aacid added a comment.


  If the old links don't work this is a problem and should be fixed in the web 
we can't break URLs just because
  
  Paging @jriddell

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D25215

To: meven, leinir, ngraham
Cc: aacid, jriddell, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D25215: Fix a couple of broken links, update links to https://kde.org/applications/, add obs

2019-11-08 Thread Méven Car 
meven retitled this revision from "Fix a couple of broken links, update links 
to https://kde.org/applications/"; to "Fix a couple of broken links, update 
links to https://kde.org/applications/, add obs".
meven edited the summary of this revision.

REPOSITORY
  R304 KNewStuff

BRANCH
  arcpatch-D25215

REVISION DETAIL
  https://phabricator.kde.org/D25215

To: meven, leinir, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25215: Fix a couple of broken links, update links to https://kde.org/applications/, add obs

2019-11-08 Thread Méven Car 
meven updated this revision to Diff 69469.
meven added a comment.


  Add OBS entry to screenrecorders

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25215?vs=69460&id=69469

BRANCH
  arcpatch-D25215_1

REVISION DETAIL
  https://phabricator.kde.org/D25215

AFFECTED FILES
  data/kmoretools-desktopfiles/_update_all_files.sh
  data/kmoretools-desktopfiles/com.obsproject.Studio.desktop
  data/kmoretools-desktopfiles/com.obsproject.Studio.png
  src/kmoretools/kmoretoolspresets.cpp

To: meven, leinir, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25215: Fix a couple of broken links, update links to https://kde.org/applications/, add obs

2019-11-08 Thread Méven Car 
meven updated this revision to Diff 69470.
meven added a comment.


  Reapply some lost changes

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25215?vs=69469&id=69470

BRANCH
  arcpatch-D25215_1

REVISION DETAIL
  https://phabricator.kde.org/D25215

AFFECTED FILES
  data/kmoretools-desktopfiles/_update_all_files.sh
  data/kmoretools-desktopfiles/com.obsproject.Studio.desktop
  data/kmoretools-desktopfiles/com.obsproject.Studio.png
  src/kmoretools/kmoretoolspresets.cpp

To: meven, leinir, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25215: Fix a couple of broken links, update links to https://kde.org/applications/, add obs

2019-11-08 Thread Méven Car 
meven updated this revision to Diff 69473.
meven added a comment.


  rebase on master

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25215?vs=69470&id=69473

BRANCH
  arcpatch-D25215

REVISION DETAIL
  https://phabricator.kde.org/D25215

AFFECTED FILES
  data/kmoretools-desktopfiles/_update_all_files.sh
  data/kmoretools-desktopfiles/com.obsproject.Studio.desktop
  data/kmoretools-desktopfiles/com.obsproject.Studio.png
  src/kmoretools/kmoretoolspresets.cpp

To: meven, leinir, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25215: Fix a couple of broken links, update links to https://kde.org/applications/, add obs

2019-11-08 Thread Nathaniel Graham 
ngraham added a comment.


  In an ideal world the OBS stuff would be in a separate patch. :)

REPOSITORY
  R304 KNewStuff

BRANCH
  arcpatch-D25215

REVISION DETAIL
  https://phabricator.kde.org/D25215

To: meven, leinir, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25215: Fix a couple of broken links, update links to https://kde.org/applications/, add obs

2019-11-08 Thread Méven Car 
meven updated this revision to Diff 69474.
meven added a comment.


  rebasing on master

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25215?vs=69473&id=69474

BRANCH
  arcpatch-D25215

REVISION DETAIL
  https://phabricator.kde.org/D25215

AFFECTED FILES
  data/kmoretools-desktopfiles/_update_all_files.sh
  data/kmoretools-desktopfiles/com.obsproject.Studio.desktop
  data/kmoretools-desktopfiles/com.obsproject.Studio.png
  src/kmoretools/kmoretoolspresets.cpp

To: meven, leinir, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns