D25296: [RFC] Fix Display Configuration icon margins

2019-12-12 Thread Nathaniel Graham 
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:5172b920f9e1: [RFC] Fix Display Configuration icon 
margins (authored by ngraham).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25296?vs=71346=71380

REVISION DETAIL
  https://phabricator.kde.org/D25296

AFFECTED FILES
  src/desktoptheme/breeze/icons/preferences.svg

To: ngraham, #vdg, ndavis
Cc: trickyricky26, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25296: [RFC] Fix Display Configuration icon margins

2019-12-12 Thread Noah Davis 
ndavis accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fix-xrandr-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25296

To: ngraham, #vdg, ndavis
Cc: trickyricky26, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25296: [RFC] Fix Display Configuration icon margins

2019-12-12 Thread Nathaniel Graham 
ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25296

To: ngraham, #vdg, ndavis
Cc: trickyricky26, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25296: [RFC] Fix Display Configuration icon margins

2019-12-12 Thread Nathaniel Graham 
ngraham updated this revision to Diff 71346.
ngraham added a comment.


  Finally fix this thing

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25296?vs=69815=71346

BRANCH
  fix-xrandr-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25296

AFFECTED FILES
  src/desktoptheme/breeze/icons/preferences.svg

To: ngraham, #vdg, ndavis
Cc: trickyricky26, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25296: [RFC] Fix Display Configuration icon margins

2019-12-06 Thread Noah Davis 
ndavis added a comment.


  In D25296#563291 , @ngraham wrote:
  
  > Never mind, I wasn't deleting the cache files properly after rebuilding. 
When I do that, the monochrome icons don't get used at all and it reverts to 
the colorful one:
  >  F778: Screenshot_20191116_084222.png 

  
  
  The color vs monochrome issue strikes again :(
  
  Maybe remove the size prefix from the 32px version? If that doesn't work, 
I've got nothing.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25296

To: ngraham, #vdg, ndavis
Cc: trickyricky26, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25296: [RFC] Fix Display Configuration icon margins

2019-12-06 Thread Nathaniel Graham 
ngraham added a subscriber: trickyricky26.
ngraham added a comment.


  @ndavis or @trickyricky26, could I ping you on this?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25296

To: ngraham, #vdg, ndavis
Cc: trickyricky26, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25296: [RFC] Fix Display Configuration icon margins

2019-11-16 Thread Nathaniel Graham 
ngraham added a comment.


  Never mind, I wasn't deleting the cache files properly after rebuilding. When 
I do that, the monochrome icons don't get used at all and it reverts to the 
colorful one:
  F778: Screenshot_20191116_084222.png 


REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25296

To: ngraham, #vdg, ndavis
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25296: [RFC] Fix Display Configuration icon margins

2019-11-16 Thread Nathaniel Graham 
ngraham added a comment.


  Hmm, if I change that, the icon disappears entirely when displayed at the 
22px size: F7766627: Screenshot_20191116_082035.png 


REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25296

To: ngraham, #vdg, ndavis
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25296: [RFC] Fix Display Configuration icon margins

2019-11-15 Thread Noah Davis 
ndavis added a comment.


  I figured it out. The 22px version needs the `22-22-` prefix in its ID.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25296

To: ngraham, #vdg, ndavis
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25296: [RFC] Fix Display Configuration icon margins

2019-11-15 Thread Nathaniel Graham 
ngraham updated this revision to Diff 69815.
ngraham marked 4 inline comments as done.
ngraham added a comment.


  - Fix stylesheet and color-changing ability
  - Vertical lines still blurry; not sure why

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25296?vs=69716=69815

BRANCH
  fix-xrandr-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25296

AFFECTED FILES
  src/desktoptheme/breeze/icons/preferences.svg

To: ngraham, #vdg, ndavis
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25296: [RFC] Fix Display Configuration icon margins

2019-11-15 Thread Noah Davis 
ndavis added inline comments.

INLINE COMMENTS

> preferences.svg:4
> +.ColorScheme-Text {
>  color:#7B7C7E;
>}

Wrong default colors. Just replace the whole stylesheet with this one: 
https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#Breeze

> preferences.svg:36
> +  }
> +

D25296: [RFC] Fix Display Configuration icon margins

2019-11-15 Thread Noah Davis 
ndavis added a comment.


  It's blurry in your screenshot because you're scaling a 22px icon up to 32px. 
The solution is to make a 32px version named 
`32-32-preferences-desktop-display-randr`. BTW, the icon is not actually 
aligned with the grid. It's a little off here and there. You should be able to 
fix it easily with the node tool by snapping nodes to the grid.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25296

To: ngraham, #vdg, ndavis
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25296: [RFC] Fix Display Configuration icon margins

2019-11-13 Thread Nathaniel Graham 
ngraham created this revision.
ngraham added reviewers: VDG, ndavis.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  The icon's old margins were too large, causing it to stick out.
  
  However in the process of fixing this, I managed to break the stylesheet so 
it no longer
  changes its colors and make the icon blurry, despite the fact that it appears 
perfectly
  pixel-aligned to the Inkscape grid.
  
  #VDG  assistance would be appreciated 
to help me figure out what's wrong here.
  
  BUG: 400087
  FIXED-IN; 5.65

TEST PLAN
  F7762410: half-fixed.png 

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fix-xrandr-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25296

AFFECTED FILES
  src/desktoptheme/breeze/icons/preferences.svg

To: ngraham, #vdg, ndavis
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns