D25308: when kioslave5 couldn't be found in libexec-ish locations try $PATH

2019-11-19 Thread Harald Sitter 
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:eab483fa2eab: when kioslave5 couldn't be found in 
libexec-ish locations try $PATH (authored by sitter).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D25308?vs=69757&id=69995#toc

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25308?vs=69757&id=69995

REVISION DETAIL
  https://phabricator.kde.org/D25308

AFFECTED FILES
  src/core/slave.cpp

To: sitter, dfaure, apol
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25308: when kioslave5 couldn't be found in libexec-ish locations try $PATH

2019-11-15 Thread Anthony Fieroni 
anthonyfieroni added inline comments.

INLINE COMMENTS

> slave.cpp:521
> +// isn't the same as applicationDirPath().
> +QString kioslaveExecutable = 
> QStandardPaths::findExecutable(QStringLiteral("kioslave5"));
> +}

Remove QString declaration before.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25308

To: sitter, dfaure, apol
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25308: when kioslave5 couldn't be found in libexec-ish locations try $PATH

2019-11-15 Thread Aleix Pol Gonzalez 
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25308

To: sitter, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25308: when kioslave5 couldn't be found in libexec-ish locations try $PATH

2019-11-14 Thread Harald Sitter 
sitter created this revision.
sitter added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  on windows we install the binary to bin/ where software that uses kio
  can find it through applicationDirPath() ordinarily. at test-time however
  applicationDirPath() of the test != finalPath, so the only way a test
  can possibly find the helper is through $PATH.
  
  this should fix the drkonqi connection test on win32 on build.kde.org

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25308

AFFECTED FILES
  src/core/slave.cpp

To: sitter, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns