D25334: Added transparent blue background to tabbars

[Nathaniel Graham]

ngraham added a comment.


  Is there a reason why we can't do this? I like it...

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, 
cblack, GB_2, michaelh, bruns

D25334: Added transparent blue background to tabbars

[Niccolò Venerandi]

niccolove abandoned this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, 
cblack, GB_2, michaelh, bruns

D25334: Added transparent blue background to tabbars

[Noah Davis]

ndavis added a comment.


  In D25334#578285 , @niccolove 
wrote:
  
  > Breeze dark highlight is currently #3daee9 in the Breeze Dark colorscheme. 
If that's too light, we could darken it there, right?
  >  Currently it's: F7819764: Screenshot_20191215_163924.png 

  >  Darker could be (example value):
  >  F7819766: Screenshot_20191215_164056.png 

  >  Otherwise, the highlight effect could be made more transparent so that 
it's darker, but that would be a problem for consistency, as the same highlight 
color is also used throughout the desktop theme.
  
  
  The base highlight color is not the problem, it's the background area based 
on the highlight color.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25334: Added transparent blue background to tabbars

[Niccolò Venerandi]

niccolove added a comment.


  Breeze dark highlight is currently #3daee9 in the Breeze Dark colorscheme. If 
that's too light, we could darken it there, right?
  Currently it's: F7819764: Screenshot_20191215_163924.png 

  Darker could be (example value):
  F7819766: Screenshot_20191215_164056.png 

  Otherwise, the highlight effect could be made more transparent so that it's 
darker, but that would be a problem for consistency, as the same highlight 
color is also used throughout the desktop theme.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25334: Added transparent blue background to tabbars

[Niccolò Venerandi]

niccolove added a comment.


  In D25334#566992 , @ngraham wrote:
  
  > In D25334#566745 , @ndavis wrote:
  >
  > > Yes that's right, the Kickoff tabs are fine, it's the panel that doesn't 
look right. It just doesn't look good with that kind of highlight to me. Or 
maybe the highlight background is too bright.
  >
  >
  > To me it looks fine with Breeze light IMO. If you think it looks bad with 
Breeze Dark, that seems like kind of a problem since as far as I was aware, 
this is the proposed new highlight style that you're working on, right? It 
definitely needs to look good with Breeze Dark, or at least no worse than the 
status quo.
  
  
  As per the screenshot above, this patch highlight look just as it was before 
in Breeze Dark, there was no change of that. If you think the current highlight 
is wrong with breeze dark, I could create a different task for that.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25334: Added transparent blue background to tabbars

[Noah Davis]

ndavis added a comment.


  In D25334#566992 , @ngraham wrote:
  
  > In D25334#566745 , @ndavis wrote:
  >
  > > Yes that's right, the Kickoff tabs are fine, it's the panel that doesn't 
look right. It just doesn't look good with that kind of highlight to me. Or 
maybe the highlight background is too bright.
  >
  >
  > To me it looks fine with Breeze light IMO. If you think it looks bad with 
Breeze Dark, that seems like kind of a problem since as far as I was aware, 
this is the proposed new highlight style that you're working on, right? It 
definitely needs to look good with Breeze Dark, or at least no worse than the 
status quo.
  
  
  I've found that breeze dark needs high chroma dark blue for the background to 
look good. It's easy enough to do with `KColorUtils::tint()` (doesn't work the 
same as `Qt.tint()` in QML), but I don't know how you'd do that in SVG. When 
you use semi-transparency for a higher chroma color on top of a background with 
lower chroma, it reduces the chroma of the higher chroma color.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25334: Added transparent blue background to tabbars

[Nathaniel Graham]

ngraham added a comment.


  In D25334#566745 , @ndavis wrote:
  
  > Yes that's right, the Kickoff tabs are fine, it's the panel that doesn't 
look right. It just doesn't look good with that kind of highlight to me. Or 
maybe the highlight background is too bright.
  
  
  To me it looks fine with Breeze light IMO. If you think it looks bad with 
Breeze Dark, that seems like kind of a problem since as far as I was aware, 
this is the proposed new highlight style that you're working on, right? It 
definitely needs to look good with Breeze Dark, or at least no worse than the 
status quo.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25334: Added transparent blue background to tabbars

[Noah Davis]

ndavis added a comment.


  In D25334#566524 , @niccolove 
wrote:
  
  > F7780227: Screenshot_20191123_130602.png 

  >  I'm sorry, isn't this right?
  >  The top one was like that before, and I just edited the bottom one, and 
they seem to be the same; shouldn't it be right then?
  
  
  Yes, that's right, it's the panel that doesn't look right.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25334: Added transparent blue background to tabbars

[Niccolò Venerandi]

niccolove added a comment.


  F7780227: Screenshot_20191123_130602.png 

  I'm sorry, isn't this right?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25334: Added transparent blue background to tabbars

[Noah Davis]

ndavis added a comment.


  Here's the fixed file: F680: tabbar.svg 

  Unfortunately, it still doesn't look right.
  F681: Screenshot_20191121_160905.png 


REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25334: Added transparent blue background to tabbars

[Noah Davis]

ndavis added inline comments.

INLINE COMMENTS

> ndavis wrote in tabbar.svg:47
> Oh wait, this must be where the color problem is. It's hardcoded to a light 
> color.

It should be ButtonFocus with semi-transparency instead.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25334: Added transparent blue background to tabbars

[Noah Davis]

ndavis added inline comments.

INLINE COMMENTS

> tabbar.svg:47
> +
> + height="12" fill="#93cee9" opacity=".34"/>
> + height="12" fill="#93cee9" opacity=".34"/>

Oh wait, this must be where the color problem is. It's hardcoded to a light 
color.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25334: Added transparent blue background to tabbars

[Noah Davis]

ndavis added a comment.


  In D25334#565851 , @ngraham wrote:
  
  > Are you talking about the effect itself in terms of its background color, 
or how it fits in the space available when displayed by widgets? The latter 
will require many complicated changes in various places to fix, but can't the 
former be fixed in this patch?
  
  
  I'm talking about both. I believe the former may also be complicated since I 
don't know where the problem is coming from. It should have been as simple as 
setting the opacity to an appropriate level, but something is tinting the 
background white.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25334: Added transparent blue background to tabbars

[Nathaniel Graham]

ngraham added a comment.


  Are you talking about the effect itself in terms of its background color, or 
how it fits in the space available when displayed by widgets? The latter will 
require many complicated changes in various places to fix, but can't the former 
be fixed in this patch?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25334: Added transparent blue background to tabbars

[Noah Davis]

ndavis added a comment.


  In D25334#565798 , @ngraham wrote:
  
  > Honestly I think this is fine to land now. We can incrementally improve 
things with patches to individual widgets, but for the most part I think this 
is a big improvement already.
  
  
  I disagree. Maybe it looks good enough on Breeze, but it looks pretty bad on 
Breeze Dark, even if it's not the fault of this patch. If those issues didn't 
get fixed before the next frameworks release, we'd have to revert this commit.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25334: Added transparent blue background to tabbars

[Nathaniel Graham]

ngraham added a comment.


  Honestly I think this is fine to land now. We can incrementally improve 
things with patches to individual widgets, but for the most part I think this 
is a big improvement already.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25334: Added transparent blue background to tabbars

[Nathaniel Graham]

ngraham added a comment.


  In D25334#563841 , @ndavis wrote:
  
  > Even if the colors are fixed, there are a number of other places that need 
fixes in order for this to look right, so I think we should hold off landing 
this until these issues are fixed:
  >  Not extending to the edge: F7768790: Screenshot_20191117_171047.png 

  
  
  This was originally fixed by D19745 , but 
that got reverted in 2594eb1b33b56ec7e0e8eb6c37acb1c7f2a5a1ff 
 
because it caused other regressions that the patch author never returned to 
correct. We'd need to revisit this and do it in a regression-free manner.
  
  > Something about this feels wrong: F7768797: Screenshot_20191117_171225.png 

  
  I agree. IMO double-width panels need to increase the size of the icons by 
default, because having a grid rather than a row is just awful and encourages 
the use of like 20 icons. We get many bug reports about people wanting this 
changed by default: https://bugs.kde.org/show_bug.cgi?id=360333 It's easily 
worked around locally by adding `iconSize=2` to 
`~/.config/plasma-org.kde.plasma.desktop-appletsrc` in the section that has 
`extraItems=` in it. It's a pretty trivial solution that works fairly well as 
the icons scale themselves down when the panel is shorter. Looks like this with 
a double-height panel: F7769037: Screenshot_20191117_183648.png 

  
  Maybe worth investigating.
  
  > Same here: F7768799: Screenshot_20191117_171323.png 

  
  Looks like a lack of adequate side margins. This code is super fragile, 
sadly. I can give it a look-see.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25334: Added transparent blue background to tabbars

[Noah Davis]

ndavis requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25334: Added transparent blue background to tabbars

[Noah Davis]

ndavis added a comment.


  Even if the colors are fixed, there are a number of other places that need 
fixes in order for this to look right, so I think we should hold off landing 
this until these issues are fixed:
  Not extending to the edge: F7768790: Screenshot_20191117_171047.png 

  Something about this feels wrong: F7768797: Screenshot_20191117_171225.png 

  Same here: F7768799: Screenshot_20191117_171323.png 

  
  These may need separate patches to the code that controls the widgets.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  tabbar_blue_background (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25334: Added transparent blue background to tabbars

[Noah Davis]

ndavis added a comment.


  These colors don't look right
  F7768670: Screenshot_20191117_152000.png 


REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  tabbar_blue_background (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25334: Added transparent blue background to tabbars

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  This seems perfect to me. A big visual improvement IMO. Any objections?

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  tabbar_blue_background (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25334: Added transparent blue background to tabbars

[Niccolò Venerandi]

niccolove updated this revision to Diff 69879.
niccolove added a comment.


  Resized 2px tabbar line to 3px

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25334?vs=69841&id=69879

BRANCH
  tabbar_blue_background (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25334

AFFECTED FILES
  src/desktoptheme/breeze/widgets/tabbar.svg

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25334: Added transparent blue background to tabbars

[Nathaniel Graham]

ngraham added a comment.


  Can you remove the line width changes from this? When this patch just adds 
the transparent blue background, I think it's pretty uncontroversial and read 
to land quickly.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25334: Added transparent blue background to tabbars

[Noah Davis]

ndavis added a comment.


  In D25334#563295 , @niccolove 
wrote:
  
  > In D25334#563285 , @ngraham 
wrote:
  >
  > > Perfect, all issues fixed, and thanks for pointing  me in the direction 
of the cache files. Deleting those fixed a bunch of other issues I was having 
with applying plasma theme SVG changes.
  >
  >
  > Did it fix the shadows? I can't apply my own shadows to the new distro I'm 
using.
  >
  > Regarding this task, I just realized a possible problem: 
  >  I originally copied this effect from the highlight effect that's used when 
you hover on applications, which uses a 3px blue line:
  >  F774: Screenshot_20191116_164209.png 

  >  But then, tweaking things around, I realized that a 2px line looks way 
better in my panel, imo:
  >  F776: Screenshot_20191116_164303.png 

  >  Therefore right now this effect and the application hover effect are 
inconsistent. I'm not a fan of bringing back that 3px line though. Do you think 
I should change the application top lines, or leave them as-is?
  
  
  If we use a 2px line here, then using a 2px outline for button focus in 
D24706  would be more acceptable. If a 2px 
line looks good in the task manager, it might be worth making the change.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25334: Added transparent blue background to tabbars

[Noah Davis]

ndavis added a comment.


  In D25334#563346 , @ngraham wrote:
  
  > Found the bug report tracking that requested change: 
https://bugs.kde.org/show_bug.cgi?id=370465
  >
  > Based on the comments there, it's likely that this proposal would receive 
pushback, and we should endeavor to understand why it was changed to the 
current state in the first place. That's not a reason to hold back on doing it, 
we just need to understand the history and make the change for legitimate 
usability-based reasons so it's not perceived as "flipping things back and 
forth over and over again".
  
  
  The relevant quote:
  
  > Kai Uwe Broulik 2018-04-03 07:51:10 UTC 
  >  We had exactly what you suggest for a while and then it was changed back 
to line art. Can we stop randomly changing theme whenever someone comes by and 
doesn't like something unless it actually comes enclosed with a 20 page 
empirical study made in a lab or something?
  
  Looks like he's referring to using only colored backgrounds, which is not 
what we're doing now. I do think the current way of showing window state is 
visually a bit confusing.
  
  Here's what I think:
  
  - The line should indicate that the app is opened, the window is not 
minimized and the window is focused (opaque blue) or inactive (opaque gray)
  - The background should indicate whether an app is not opened (no BG), 
minimized or inactive (semi-transparent gray), or focused (semi-transparent 
blue)
  
  This way it mostly doesn't change, but the visuals have more of a logical 
relation to each other.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25334: Added transparent blue background to tabbars

[Nathaniel Graham]

ngraham added a comment.


  In D25334#563345 , @niccolove 
wrote:
  
  > In D25334#563334 , @ngraham 
wrote:
  >
  > > If you wanna do that, let's split it out into a different patch though.
  >
  >
  > Sure. Should this patch land first, or should I try to make two at the same 
time?
  
  
  You can do two patches at once. Just do each on a separate git branch, and 
then they won't interfere with one another. See 
https://community.kde.org/Infrastructure/Phabricator#Workflow

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25334: Added transparent blue background to tabbars

[Nathaniel Graham]

ngraham added a comment.


  Found the bug report tracking that requested change: 
https://bugs.kde.org/show_bug.cgi?id=370465
  
  Based on the comments there, it's likely that this proposal would receive 
pushback, and we should endeavor to understand why it was changed to the 
current state in the first place. That's not a reason to hold back on doing it, 
we just need to understand the history and make the change for legitimate 
usability-based reasons so it's not perceived as "flipping things back and 
forth over and over again".

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25334: Added transparent blue background to tabbars

[Niccolò Venerandi]

niccolove added a comment.


  In D25334#563334 , @ngraham wrote:
  
  > If you wanna do that, let's split it out into a different patch though.
  
  
  Sure. Should this patch land first, or should I try to make two at the same 
time?

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25334: Added transparent blue background to tabbars

[Nathaniel Graham]

ngraham added a comment.


  If you wanna do that, let's split it out into a different patch though.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25334: Added transparent blue background to tabbars

[Nathaniel Graham]

ngraham added a comment.


  In D25334#563308 , @niccolove 
wrote:
  
  > F7766720: Screenshot_20191116_172052.png 

  >  I think that this last one looks much prettier and usable, but that's just 
an idea I only wanted to try, feel free to tell me that's not a good idea. 
Also, changing the background colors there could also be done regardless of the 
line thickness. I just felt like it was much prettier.
  
  
  I agree 100%, and in fact this is also something I have wanted for a long 
time. It would be a big improvement IMO. There's a bug report requesting this 
somewhere, I just need to find it...

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25334: Added transparent blue background to tabbars

[Niccolò Venerandi]

niccolove added a comment.


  In D25334#563301 , @ngraham wrote:
  
  > If anything, I think the tab bar line should increase to be 3px to match 
the open app task manager highlight. If we do the reverse, the highlight for 
open app swill be too subtle IMO.
  
  
  Uhm, what if we drew the blue background for the active app? That is what 
Windows does as well, and I think it makes sense. When you open a widget, the 
window will lose focus, so there will never be two elements with blue 
background in the panel. Hover is still clearly visible. See:
  Before:
  F7766706: Screenshot_20191116_170621.png 

  After:
  F7766713: Screenshot_20191116_171634.png 

  At this point open-but-inactive applications could be made more visible by 
adding a gray background as transparent as the blue on.
  F7766720: Screenshot_20191116_172052.png 

  I think that this last one looks much prettier and usable, but that's just an 
idea I only wanted to try, feel free to tell me that's not a good idea. Also, 
changing the background colors there could also be done regardless of the line 
thickness. I just felt like it was much prettier.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25334: Added transparent blue background to tabbars

[Nathaniel Graham]

ngraham added a comment.


  If anything, I think the tab bar line should increase to be 3px to match the 
open app task manager highlight. If we do the reverse, the highlight for open 
app swill be too subtle IMO.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25334: Added transparent blue background to tabbars

[Niccolò Venerandi]

niccolove added a comment.


  In D25334#563285 , @ngraham wrote:
  
  > Perfect, all issues fixed, and thanks for pointing  me in the direction of 
the cache files. Deleting those fixed a bunch of other issues I was having with 
applying plasma theme SVG changes.
  
  
  Did it fix the shadows? I can't apply my own shadows to the new distro I'm 
using.
  
  Regarding this task, I just realized a possible problem: 
  I originally copied this effect from the highlight effect that's used when 
you hover on applications, which uses a 3px blue line:
  F774: Screenshot_20191116_164209.png 

  But then, tweaking things around, I realized that a 2px line looks way better 
in my panel, imo:
  F776: Screenshot_20191116_164303.png 

  Therefore right now this effect and the application hover effect are 
inconsistent. I'm not a fan of bringing back that 3px line though. Do you think 
I should change the application top lines, or leave them as-is?

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25334: Added transparent blue background to tabbars

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Perfect, all issues fixed, and thanks for pointing  me in the direction of 
the cache files. Deleting those fixed a bunch of other issues I was having with 
applying plasma theme SVG changes.
  
  This looks great to me.
  
  Other VDG or #plasma  folks, any 
comments?

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25334: Added transparent blue background to tabbars

[Niccolò Venerandi]

niccolove added a comment.


  In D25334#563265 , @ngraham wrote:
  
  > Did you change the SVGs for vertical tab bars as well?
  
  
  Uh, yes I did. Try deleting the plasma theme + svg cache in .cache
  
  > I also noticed one visual papercut in the plasma-pa tab bar: the blue line 
highlight becomes thinner on the right edge: F7766617: 
Screenshot_20191116_081301.png 
  > 
  > Any idea what's up with that?
  
  Fixed, my bad. Or, better put, OOPSIE WOOPSIE!! Uwu I made a fucky wucky!! A 
wittle fucko boingo!

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25334: Added transparent blue background to tabbars

[Niccolò Venerandi]

niccolove updated this revision to Diff 69841.
niccolove added a comment.


  Fixed broken north bottom-left tabbar line

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25334?vs=69840&id=69841

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25334

AFFECTED FILES
  src/desktoptheme/breeze/widgets/tabbar.svg

To: niccolove, #vdg
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25334: Added transparent blue background to tabbars

[Nathaniel Graham]

ngraham added subscribers: ndavis, ngraham.
ngraham added a comment.


  This is great, I've wanted Plasma tabs to look like this for ages. It gels 
very well with the in-progress highlight changes that @ndavis is working on. 
However for me it only seems to take effect for horizontal tab bars. Did you 
change the SVGs for vertical tab bars as well?
  
  I also noticed one visual papercut in the plasma-pa tab bar: the blue line 
highlight becomes thinner on the right edge: F7766617: 
Screenshot_20191116_081301.png 
  
  Any idea what's up with that?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25334: Added transparent blue background to tabbars

[Niccolò Venerandi]

niccolove added a comment.


  In D25334#563254 , @KonqiDragon 
wrote:
  
  > Something like this looks better and clearer.
  >  F6924045: grafik.png 
  
  
  That's because no element was selected. If you select an element, only that 
one appears selected:
  F7766584: Screenshot_20191116_154652.png 


REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg
Cc: KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D25334: Added transparent blue background to tabbars

[KonqiDragon]

KonqiDragon added a comment.


  Is it possible to make the  selection of system tray visually more cleary? 
  On this screenshot i see that opened the "Status and Notifications" tray 
popup,  but it looks like that selected all in the system tray
  F7766344: Screenshot_20191116_121454.png 

  Something like this looks better and clearer.
  F6924045: grafik.png 

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg
Cc: KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D25334: Added transparent blue background to tabbars

[Niccolò Venerandi]

niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg
Cc: #vdg, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25334: Added transparent blue background to tabbars

[Niccolò Venerandi]

niccolove updated this revision to Diff 69840.
niccolove edited the summary of this revision.
niccolove added a comment.


  Resized blue line of tabbars

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25334?vs=69833&id=69840

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25334

AFFECTED FILES
  src/desktoptheme/breeze/widgets/tabbar.svg

To: niccolove, #vdg
Cc: #vdg, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25334: Added transparent blue background to tabbars

[Niccolò Venerandi]

niccolove edited the summary of this revision.
niccolove edited the test plan for this revision.
niccolove added a reviewer: VDG.
niccolove added a subscriber: VDG.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg
Cc: #vdg, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25334: Added transparent blue background to tabbars

[Niccolò Venerandi]

niccolove created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
niccolove requested review of this revision.

REVISION SUMMARY
  Used the T11124  highlight effect for 
breeze tabbars by editing the file widgets/tabbar.svg.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  tabbar_blue_background (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25334

AFFECTED FILES
  src/desktoptheme/breeze/widgets/tabbar.svg

To: niccolove
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns