D25355: [Samba] Improve warning message about netbios name

2019-11-18 Thread Méven Car
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:3874f9f8a4b7: [Samba] Improve warning message about 
netbios name (authored by meven).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25355?vs=69921&id=69923

REVISION DETAIL
  https://phabricator.kde.org/D25355

AFFECTED FILES
  src/core/ksambashare.cpp

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D25355: [Samba] Improve warning message about netbios name

2019-11-18 Thread Méven Car
meven updated this revision to Diff 69921.
meven added a comment.


  Improve reliability

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25355?vs=69878&id=69921

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25355

AFFECTED FILES
  src/core/ksambashare.cpp

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D25355: [Samba] Improve warning message about netbios name

2019-11-17 Thread Nathaniel Graham
ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25355

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D25355: [Samba] Improve warning message about netbios name

2019-11-17 Thread Méven Car
meven updated this revision to Diff 69878.
meven edited the summary of this revision.
meven added a comment.


  Fix

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25355?vs=69877&id=69878

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25355

AFFECTED FILES
  src/core/ksambashare.cpp

To: meven, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D25355: [Samba] Improve warning message about netbios name

2019-11-17 Thread Méven Car
meven edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25355

To: meven, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D25355: [Samba] Improve warning message about netbios name

2019-11-17 Thread Méven Car
meven updated this revision to Diff 69877.
meven added a comment.


  Display leftovers warnings if any

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25355?vs=69876&id=69877

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25355

AFFECTED FILES
  src/core/ksambashare.cpp

To: meven, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D25355: [Samba] Improve warning message about netbios name

2019-11-17 Thread Méven Car
meven created this revision.
meven added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  Before:
  kf5.kio.core: We got some errors while running testparm "Load smb config 
files from /etc/samba/smb.conf\nLoaded services file OK.\nWARNING: The 'netbios 
name' is too long (max. 15 chars).\n\n"
  
  After:
  kf5.kio.core: The samba 'netbios name' parameter was longer than the 
authorized 15 characters. It may be because your hostname is longer than 13 and 
samba default 'netbios name' defaults to 'hostname-W' If that it is the case 
simply define a netbios name parameter in /etc/samba/smb.conf at most 15 
characters long

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25355

AFFECTED FILES
  src/core/ksambashare.cpp

To: meven, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns