D25708: Don't use nullptr to flags

2019-12-03 Thread Albert Astals Cid 
aacid added a comment.


  To be clear, that works just fine, it's just weird and deprecated on 5.15, 
but it's not "incorrect" code

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D25708

To: mlaurent, romangg, zzag
Cc: aacid, zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25708: Don't use nullptr to flags

2019-12-03 Thread Laurent Montel 
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:b3c7074431d0: Dont use nullptr to flags (authored 
by mlaurent).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25708?vs=70807=70811

REVISION DETAIL
  https://phabricator.kde.org/D25708

AFFECTED FILES
  src/client/xdgshell_stable.cpp
  src/client/xdgshell_v6.cpp

To: mlaurent, romangg, zzag
Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25708: Don't use nullptr to flags

2019-12-03 Thread Vlad Zahorodnii 
zzag accepted this revision.
zzag added a comment.
This revision is now accepted and ready to land.


  > IT seems that it was a error during modernize code by using nullptr
  
  Yeah, we had the same issue with running modernize-use-nullptr over kwin's 
code base.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D25708

To: mlaurent, romangg, zzag
Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25708: Don't use nullptr to flags

2019-12-02 Thread Laurent Montel 
mlaurent added a reviewer: romangg.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D25708

To: mlaurent, romangg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25708: Don't use nullptr to flags

2019-12-02 Thread Laurent Montel 
mlaurent created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  IT seems that it was a error during modernize code by using nullptr
  but it's a flags so we can't use it

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D25708

AFFECTED FILES
  src/client/xdgshell_stable.cpp
  src/client/xdgshell_v6.cpp

To: mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns