D25793: Rename "Configure Shortcuts" to "Configure Keyboard Shortcuts"

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R265:df95c485f47c: Rename "Configure Shortcuts" to 
"Configure Keyboard Shortcuts" (authored by ngraham).

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25793?vs=71031&id=71156

REVISION DETAIL
  https://phabricator.kde.org/D25793

AFFECTED FILES
  src/kstandardaction_p.h

To: ngraham, #vdg, ndavis
Cc: ltoscano, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25793: Rename "Configure Shortcuts" to "Configure Keyboard Shortcuts"

[Luigi Toscano]

ltoscano added a comment.


  Oh sorry, I missed that. It's the kind of information I wouldn't expect in 
the commit message.

REPOSITORY
  R265 KConfigWidgets

BRANCH
  configure-keyboard-shortcuts (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25793

To: ngraham, #vdg, ndavis
Cc: ltoscano, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25793: Rename "Configure Shortcuts" to "Configure Keyboard Shortcuts"

[Nathaniel Graham]

ngraham added a comment.


  Yep, in fact I mentioned this in the description section of the patch:
  
  > If accepted, will wait until after tagging to land it so as not to break 
the string freeze.

REPOSITORY
  R265 KConfigWidgets

BRANCH
  configure-keyboard-shortcuts (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25793

To: ngraham, #vdg, ndavis
Cc: ltoscano, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25793: Rename "Configure Shortcuts" to "Configure Keyboard Shortcuts"

[Luigi Toscano]

ltoscano added a comment.


  Please commit it after the commit for the new Frameworks is made (so probably 
from Sunday onwards).

REPOSITORY
  R265 KConfigWidgets

BRANCH
  configure-keyboard-shortcuts (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25793

To: ngraham, #vdg, ndavis
Cc: ltoscano, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25793: Rename "Configure Shortcuts" to "Configure Keyboard Shortcuts"

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  Welp, there's nothing objectively wrong with making this patch. LGTM

REPOSITORY
  R265 KConfigWidgets

BRANCH
  configure-keyboard-shortcuts (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25793

To: ngraham, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25793: Rename "Configure Shortcuts" to "Configure Keyboard Shortcuts"

[Nathaniel Graham]

ngraham added a comment.


  There was a bug report about it that had some people agreeing with it. I 
think it makes a bit of sense because yes, this dialog is indeed only about 
keyboard shortcuts, and at least to my ears, the phrase "keyboard shortcuts" 
instantly connotes what this is about, while "shortcuts" is a more generic term 
that doesn't have such an instantly recognizable computer-related meaning.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25793

To: ngraham, #vdg
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25793: Rename "Configure Shortcuts" to "Configure Keyboard Shortcuts"

[Noah Davis]

ndavis added a comment.


  This doesn't seem wrong, but why is it needed? Do people get confused about 
the type of shortcuts? Are there non-keyboard shortcuts? If there are, would we 
put their configuration menu under a different menu option?

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25793

To: ngraham, #vdg
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25793: Rename "Configure Shortcuts" to "Configure Keyboard Shortcuts"

[Nathaniel Graham]

ngraham created this revision.
ngraham added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This is a bit clearer, and reinforces the keyboard icon used for the menu 
item.
  
  BUG: 39488
  FIXED-IN: 5.66
  
  If accepted, will wait until after tagging to land it so as not to break the 
string freeze.

TEST PLAN
  F7802662: Configure keyboard shortcuts.png 


REPOSITORY
  R265 KConfigWidgets

BRANCH
  configure-keyboard-shortcuts (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25793

AFFECTED FILES
  src/kstandardaction_p.h

To: ngraham, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns