D25865: kfilemetadata EBN transport protocol cleanup

2020-03-04 Thread John Hayes 
jhayes abandoned this revision.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D25865

To: jhayes
Cc: vkrause, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D25865: kfilemetadata EBN transport protocol cleanup

2019-12-17 Thread John Hayes 
jhayes updated this revision to Diff 71751.
jhayes added a comment.


  - Reversed URI changes

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25865?vs=71236&id=71751

BRANCH
  ebn-transport-cleanup (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25865

AFFECTED FILES
  src/extractors/dublincoreextractor.cpp

To: jhayes
Cc: vkrause, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D25865: kfilemetadata EBN transport protocol cleanup

2019-12-16 Thread John Hayes 
jhayes added a comment.


  You're right, can we just close this?
  
  John

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D25865

To: jhayes
Cc: vkrause, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D25865: kfilemetadata EBN transport protocol cleanup

2019-12-11 Thread Volker Krause 
vkrause added inline comments.

INLINE COMMENTS

> xmlextractor.cpp:33
> +inline QString rdfNS(){ return 
> QStringLiteral("https://www.w3.org/1999/02/22-rdf-syntax-ns#";); }
> +inline QString ccNS() { return 
> QStringLiteral("https://creativecommons.org/ns#";); }
>  

sure about those? they look suspiciously like XML namespace URIs, not URLs?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D25865

To: jhayes
Cc: vkrause, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D25865: kfilemetadata EBN transport protocol cleanup

2019-12-10 Thread John Hayes 
jhayes created this revision.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
jhayes requested review of this revision.

REVISION SUMMARY
  Change tranport protocol from http to https and verify address

REPOSITORY
  R286 KFileMetaData

BRANCH
  ebn-transport-cleanup (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25865

AFFECTED FILES
  src/extractors/dublincoreextractor.cpp
  src/extractors/xmlextractor.cpp

To: jhayes
Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams