D26034: Replace KLocalSocket with QLocalSocket

[David Faure]

dfaure added a comment.


  It built but apparently the unittests for KIO are disabled on CI :(

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26034

To: nicolasfella, #frameworks, dfaure
Cc: cullmann, vonreth, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D26034: Replace KLocalSocket with QLocalSocket

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:28da79f2119e: Replace KLocalSocket with QLocalSocket 
(authored by nicolasfella).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26034?vs=71642&id=80188

REVISION DETAIL
  https://phabricator.kde.org/D26034

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/klocalsocketservertest.cpp
  autotests/klocalsocketservertest.h
  autotests/klocalsockettest.cpp
  autotests/klocalsockettest.h
  src/core/CMakeLists.txt
  src/core/connection.cpp
  src/core/connectionbackend.cpp
  src/core/connectionbackend_p.h
  src/core/connectionserver.cpp
  src/core/klocalsocket.cpp
  src/core/klocalsocket.h
  src/core/klocalsocket_p.h
  src/core/klocalsocket_unix.cpp
  src/core/klocalsocket_win.cpp

To: nicolasfella, #frameworks, dfaure
Cc: cullmann, vonreth, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D26034: Replace KLocalSocket with QLocalSocket

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Let's give this a try. In the absence of human testers on Windows, CI will 
tell us...

REPOSITORY
  R241 KIO

BRANCH
  klocalsocket

REVISION DETAIL
  https://phabricator.kde.org/D26034

To: nicolasfella, #frameworks, dfaure
Cc: cullmann, vonreth, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D26034: Replace KLocalSocket with QLocalSocket

[Nicolas Fella]

nicolasfella added a reviewer: dfaure.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26034

To: nicolasfella, #frameworks, dfaure
Cc: cullmann, vonreth, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D26034: Replace KLocalSocket with QLocalSocket

[Nicolas Fella]

nicolasfella edited the summary of this revision.
nicolasfella added subscribers: vonreth, cullmann.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26034

To: nicolasfella, #frameworks
Cc: cullmann, vonreth, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D26034: Replace KLocalSocket with QLocalSocket

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  As described in T12010 .
  
  AFAIU the QTcpSocket path was only used for Windows, but since QLocalSocket 
supports Windows we can just use that.
  
  This is entirely untested on Windows though.

TEST PLAN
  Did some SFTP stuff in Dolphin.
  No new tests fail

REPOSITORY
  R241 KIO

BRANCH
  klocalsocket

REVISION DETAIL
  https://phabricator.kde.org/D26034

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/klocalsocketservertest.cpp
  autotests/klocalsocketservertest.h
  autotests/klocalsockettest.cpp
  autotests/klocalsockettest.h
  src/core/CMakeLists.txt
  src/core/connection.cpp
  src/core/connectionbackend.cpp
  src/core/connectionbackend_p.h
  src/core/connectionserver.cpp
  src/core/klocalsocket.cpp
  src/core/klocalsocket.h
  src/core/klocalsocket_p.h
  src/core/klocalsocket_unix.cpp
  src/core/klocalsocket_win.cpp

To: nicolasfella, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns