D26057: Deprecate the top-level IconSize() function

[Volker Krause]

vkrause added a comment.


  In D26057#592147 , @dfaure wrote:
  
  > Please port kdeclarative.
  >
  > kdeclarative/private/kiconprovider.cpp:44:56: error: ‘IconSize’ was not 
declared in this scope
  >
  >   pixmap = 
QIcon::fromTheme(source.at(0)).pixmap(IconSize(KIconLoader::Desktop));
  >   
  >
  > Detected by http://www.davidfaure.fr/2020/542.diff (to be applied to 
kdeclarative)
  >
  > Thanks.
  
  
  Done in D26603 .

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D26057

To: vkrause, apol
Cc: dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26057: Deprecate the top-level IconSize() function

[David Faure]

dfaure added a comment.


  Please port kdeclarative.
  
  kdeclarative/private/kiconprovider.cpp:44:56: error: ‘IconSize’ was not 
declared in this scope
  
pixmap = 
QIcon::fromTheme(source.at(0)).pixmap(IconSize(KIconLoader::Desktop));
  
  Detected by http://www.davidfaure.fr/2020/542.diff (to be applied to 
kdeclarative)
  
  Thanks.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D26057

To: vkrause, apol
Cc: dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26057: Deprecate the top-level IconSize() function

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R302:3e668c7fba9f: Deprecate the top-level IconSize() function 
(authored by vkrause).

REPOSITORY
  R302 KIconThemes

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26057?vs=71689&id=71737

REVISION DETAIL
  https://phabricator.kde.org/D26057

AFFECTED FILES
  src/CMakeLists.txt
  src/kiconloader.cpp
  src/kiconloader.h

To: vkrause, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26057: Deprecate the top-level IconSize() function

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R302 KIconThemes

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26057

To: vkrause, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26057: Deprecate the top-level IconSize() function

[Volker Krause]

vkrause added a task: T11637: Investigate if KIconThemes is needed as a 
framework.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D26057

To: vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26057: Deprecate the top-level IconSize() function

[Volker Krause]

vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  This removes the last of the non-namespaced top-level functions here
  as well.

REPOSITORY
  R302 KIconThemes

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26057

AFFECTED FILES
  src/CMakeLists.txt
  src/kiconloader.cpp
  src/kiconloader.h

To: vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns