D26098: Display first / in mounted storage access description

2019-12-19 Thread Stefan Brüns 
bruns added inline comments.

INLINE COMMENTS

> fstabdevice.cpp:51
> +m_product = m_device.mid(m_device.indexOf(":/") + 1);
>  if (m_product.isEmpty()) {
>  m_product = QStringLiteral("/");

this can no longer happen then ...

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D26098

To: meven, #frameworks, bruns, ngraham, broulik
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26098: Display first / in mounted storage access description

2019-12-19 Thread Méven Car 
This revision was automatically updated to reflect the committed changes.
Closed by commit R245:ebf1d037a358: Display first / in mounted storage access 
description (authored by meven).

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26098?vs=71831=71850

REVISION DETAIL
  https://phabricator.kde.org/D26098

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabdevice.cpp

To: meven, #frameworks, bruns, ngraham, broulik
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26098: Display first / in mounted storage access description

2019-12-19 Thread Nathaniel Graham 
ngraham accepted this revision.

REPOSITORY
  R245 Solid

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26098

To: meven, #frameworks, bruns, ngraham, broulik
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26098: Display first / in mounted storage access description

2019-12-19 Thread Kai Uwe Broulik 
broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R245 Solid

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26098

To: meven, #frameworks, bruns, ngraham, broulik
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26098: Display first / in mounted storage access description

2019-12-18 Thread Méven Car 
meven created this revision.
meven added reviewers: Frameworks, bruns, ngraham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  Since f299edfeb8fd3893f9adf71a277f21a5ed50775u, for a mounted nfs drive in 
its description we have :
  what/is/mounted on from-where-ip
  
  This patch changes this to:
  /what/is/mounted on from-where-ip
  
  The description is what is displayed in places for instance.

REPOSITORY
  R245 Solid

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26098

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabdevice.cpp

To: meven, #frameworks, bruns, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns