D26276: KFilePlaceEditDialog: fix crash when editing the Trash place

2019-12-29 Thread Elvis Angelaccio 
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:a9ea007cf87c: KFilePlaceEditDialog: fix crash when 
editing the Trash place (authored by elvisangelaccio).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26276?vs=72339&id=72340

REVISION DETAIL
  https://phabricator.kde.org/D26276

AFFECTED FILES
  src/filewidgets/kfileplaceeditdialog.cpp

To: elvisangelaccio, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26276: KFilePlaceEditDialog: fix crash when editing the Trash place

2019-12-29 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Oops! Nice fix.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26276

To: elvisangelaccio, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26276: KFilePlaceEditDialog: fix crash when editing the Trash place

2019-12-29 Thread Elvis Angelaccio 
elvisangelaccio created this revision.
elvisangelaccio added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
elvisangelaccio requested review of this revision.

REVISION SUMMARY
  `m_iconButton` is initialized only when the url scheme of the place being
  edited is not `trash`.
  
  BUG: 415676
  FIXED-IN: 5.66

TEST PLAN
  Right-click the Trash place in dolphin and change the name.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26276

AFFECTED FILES
  src/filewidgets/kfileplaceeditdialog.cpp

To: elvisangelaccio, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns