D26318: Port endl to "\n" flush at the end + use const'ref in loop

2020-01-01 Thread Laurent Montel 
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:6ed68fd17385: Port endl to "\n" flush at the 
end + use const'ref in loop (authored by mlaurent).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26318?vs=72513&id=72592

REVISION DETAIL
  https://phabricator.kde.org/D26318

AFFECTED FILES
  autotests/scalabletest.cpp

To: mlaurent, dfaure, apol
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26318: Port endl to "\n" flush at the end + use const'ref in loop

2020-01-01 Thread Aleix Pol Gonzalez 
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  port_endl_qt5.15 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26318

To: mlaurent, dfaure, apol
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26318: Port endl to "\n" flush at the end + use const'ref in loop

2020-01-01 Thread Laurent Montel 
mlaurent updated this revision to Diff 72513.
mlaurent added a comment.


  merge \n or add '\n'

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26318?vs=72441&id=72513

BRANCH
  port_endl_qt5.15 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26318

AFFECTED FILES
  autotests/scalabletest.cpp

To: mlaurent, dfaure
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26318: Port endl to "\n" flush at the end + use const'ref in loop

2019-12-31 Thread Aleix Pol Gonzalez 
apol added inline comments.

INLINE COMMENTS

> scalabletest.cpp:312
>  QTextStream stream(&msg);
> -stream << "Duplicated scalable icons:" << endl;
> -for (auto icon : duplicatedScalableIcons.keys()) {
> -stream << QString("  %1:").arg(icon) << endl;
> -for (auto info : duplicatedScalableIcons[icon]) {
> -stream << QString("%1").arg(info.absoluteFilePath()) 
> << endl;
> +stream << "Duplicated scalable icons:" << "\n";
> +for (const auto &icon : duplicatedScalableIcons.keys()) {

'\n' or merge into the string.

> scalabletest.cpp:319
>  }
> +stream.flush();
>  QFAIL(qPrintable(msg));

Maybe add a {}-scope?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D26318

To: mlaurent, dfaure
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26318: Port endl to "\n" flush at the end + use const'ref in loop

2019-12-30 Thread Laurent Montel 
mlaurent added a reviewer: dfaure.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D26318

To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26318: Port endl to "\n" flush at the end + use const'ref in loop

2019-12-30 Thread Laurent Montel 
mlaurent created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  Port endl to \n

REPOSITORY
  R266 Breeze Icons

BRANCH
  port_endl_qt5.15 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26318

AFFECTED FILES
  autotests/scalabletest.cpp

To: mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns