D26532: Don't use KWindowSystem on Android

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R289:33742dde2f73: Dont use KWindowSystem on Android 
(authored by nicolasfella).

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26532?vs=73095=73343

REVISION DETAIL
  https://phabricator.kde.org/D26532

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/config-knotifications.h.cmake
  src/kpassivepopup.cpp

To: nicolasfella, #frameworks, vkrause, apol, dfaure
Cc: dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26532: Don't use KWindowSystem on Android

[David Faure]

dfaure accepted this revision.
dfaure added a comment.


  I agree with the reasoning, we can break BC on Android.

REPOSITORY
  R289 KNotifications

BRANCH
  nokwindowsystem

REVISION DETAIL
  https://phabricator.kde.org/D26532

To: nicolasfella, #frameworks, vkrause, apol, dfaure
Cc: dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26532: Don't use KWindowSystem on Android

[Aleix Pol Gonzalez]

apol accepted this revision.

REPOSITORY
  R289 KNotifications

BRANCH
  nokwindowsystem

REVISION DETAIL
  https://phabricator.kde.org/D26532

To: nicolasfella, #frameworks, vkrause, apol
Cc: dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26532: Don't use KWindowSystem on Android

[Nicolas Fella]

nicolasfella added a subscriber: dfaure.
nicolasfella added a comment.


  Pragmatically speaking I want to say 'No'.
  
  @dfaure Do you have an opinion on this?

REPOSITORY
  R289 KNotifications

BRANCH
  nokwindowsystem

REVISION DETAIL
  https://phabricator.kde.org/D26532

To: nicolasfella, #frameworks, vkrause
Cc: dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26532: Don't use KWindowSystem on Android

[Volker Krause]

vkrause added a comment.


  In D26532#590609 , @nicolasfella 
wrote:
  
  > In D26532#590598 , @vkrause 
wrote:
  >
  > > We are already not building a few things here on Android (including 
public API on other platforms), so excluding more is fine IMHO, especially if 
it's stuff where you can't argue an empty stub is a useful porting aid.
  >
  >
  > IIRC the case with KSNI on Android was a bit different since it never was 
part of the ABI on Android, whereas KPassivePopup is.
  
  
  True. But do the same ABI rules even apply to Android, given there is no way 
to distribute libraries shared between multiple consumers there, and given the 
early stages of supporting Android in KF5?

REPOSITORY
  R289 KNotifications

BRANCH
  nokwindowsystem

REVISION DETAIL
  https://phabricator.kde.org/D26532

To: nicolasfella, #frameworks, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26532: Don't use KWindowSystem on Android

[Nicolas Fella]

nicolasfella added a comment.


  In D26532#590598 , @vkrause wrote:
  
  > We are already not building a few things here on Android (including public 
API on other platforms), so excluding more is fine IMHO, especially if it's 
stuff where you can't argue an empty stub is a useful porting aid.
  
  
  IIRC the case with KSNI on Android was a bit different since it never was 
part of the ABI on Android, whereas KPassivePopup is.

REPOSITORY
  R289 KNotifications

BRANCH
  nokwindowsystem

REVISION DETAIL
  https://phabricator.kde.org/D26532

To: nicolasfella, #frameworks, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26532: Don't use KWindowSystem on Android

[Volker Krause]

vkrause accepted this revision.
vkrause added a comment.
This revision is now accepted and ready to land.


  We are already not building a few things here on Android (including public 
API on other platforms), so excluding more is fine IMHO, especially if it's 
stuff where you can't argue an empty stub is a useful porting aid.

REPOSITORY
  R289 KNotifications

BRANCH
  nokwindowsystem

REVISION DETAIL
  https://phabricator.kde.org/D26532

To: nicolasfella, #frameworks, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26532: Don't use KWindowSystem on Android

[Nicolas Fella]

nicolasfella edited the summary of this revision.
nicolasfella added a dependency: D26513: Port KNotification from KWindowSystem.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D26532

To: nicolasfella, #frameworks, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26532: Don't use KWindowSystem on Android

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added reviewers: Frameworks, vkrause.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  The usage of KWindowSystem is not relevant on Android. This saves us a 
dependency there.
  
  Ideally we wouldn't build KPassivePopup at all there, but unfortunately it is 
public API. One could argue that such a break for non-functional API on Android 
could be okay.

TEST PLAN
  Builds on Android and Linux

REPOSITORY
  R289 KNotifications

BRANCH
  nokwindowsystem

REVISION DETAIL
  https://phabricator.kde.org/D26532

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/config-knotifications.h.cmake
  src/kpassivepopup.cpp

To: nicolasfella, #frameworks, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns