D26595: Add network-wireless-hotspot icon

2020-03-06 Thread Noah Davis 
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:659e184c49d7: Add network-wireless-hotspot icon (authored 
by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26595?vs=77142=77151

REVISION DETAIL
  https://phabricator.kde.org/D26595

AFFECTED FILES
  icons-dark/devices/16/network-wireless-hotspot.svg
  icons-dark/devices/22/network-wireless-hotspot.svg
  icons/devices/16/network-wireless-hotspot.svg
  icons/devices/22/network-wireless-hotspot.svg

To: ndavis, #vdg, cblack, ngraham
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D26595: Add network-wireless-hotspot icon

2020-03-06 Thread Nathaniel Graham 
ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  arcpatch-D26595 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26595

To: ndavis, #vdg, cblack, ngraham
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D26595: Add network-wireless-hotspot icon

2020-03-06 Thread Noah Davis 
ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D26595

To: ndavis, #vdg, cblack
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D26595: Add network-wireless-hotspot icon

2020-03-06 Thread Noah Davis 
ndavis updated this revision to Diff 77142.
ndavis added a comment.


  - Update style

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26595?vs=73316=77142

BRANCH
  arcpatch-D26595 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26595

AFFECTED FILES
  icons-dark/devices/16/network-wireless-hotspot.svg
  icons-dark/devices/22/network-wireless-hotspot.svg
  icons/devices/16/network-wireless-hotspot.svg
  icons/devices/22/network-wireless-hotspot.svg

To: ndavis, #vdg, cblack
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D26595: Add network-wireless-hotspot icon

2020-02-07 Thread Noah Davis 
ndavis commandeered this revision.
ndavis added a reviewer: cblack.
ndavis added a comment.


  sure

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D26595

To: ndavis, #vdg, cblack
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D26595: Add network-wireless-hotspot icon

2020-02-07 Thread Carson Black 
cblack added a comment.


  @ndavis do you want to take over this revision? You have a better sense of 
what this icon should be than I do.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D26595

To: cblack, #vdg
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D26595: Add network-wireless-hotspot icon

2020-01-13 Thread Méven Car 
meven added a dependent revision: D26392: Add option to easily configure and 
start a hotspot.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D26595

To: cblack, #vdg
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26595: Add network-wireless-hotspot icon

2020-01-12 Thread Noah Davis 
ndavis added a comment.


  In D26595#592368 , @ngraham wrote:
  
  > Hmm, at normal size, the 8, 16, and 22px versions look too busy to me.:
  
  
  I kind of agree.
  
  > For the 16 and 22px versions, maybe reduce the number of waves and increase 
the spacing between them. And do we even need an 8px version?
  
  We don't need an 8px version.
  
  @cblack, if we did need an 8px version, you'd have to edit `index.theme` and 
define the 8px device icons folder.
  
  -
  
  One trick I learned from looking at the wifi icon is that you don't have to 
perfectly center the lines and the cut. If you offset them in a consistent way, 
you can get the spacing you want and the lines will still look fine.
  
  Here are edited versions of the 16 and 22px icons with a couple variations 
each: F7878874: network-wireless-hotspot.svg 
 F7878875: network-wireless-hotspot.svg 

  
  In the 16px version, I used a 14px outer circle, lowered it by 1px and cut it 
with a right triangle.
  
  F7878890: Screenshot_20200112_053351.PNG 

  
  In the 22px version, I cut it the same way, but only to give the triangle 
bottom variant a bit more space. It's not needed if you use the antenna variant.
  F7878893: Screenshot_20200112_053723.PNG 

  
  --
  
  I think the radio waves around the 32px version should be 1px thick.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D26595

To: cblack, #vdg
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26595: Add network-wireless-hotspot icon

2020-01-11 Thread Nathaniel Graham 
ngraham added a comment.


  Hmm, at normal size, the 8, 16, and 22px versions look too busy to me.:
  
  F7878586: Screenshot_20200111_220052.png 

  
  For the 16 and 22px versions, maybe reduce the number of waves and increase 
the spacing between them. And do we even need an 8px version?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D26595

To: cblack, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26595: Add network-wireless-hotspot icon

2020-01-11 Thread Carson Black 
cblack edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D26595

To: cblack, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26595: Add network-wireless-hotspot icon

2020-01-11 Thread Carson Black 
cblack created this revision.
cblack added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
cblack requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  hotspot-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26595

AFFECTED FILES
  icons-dark/devices/16/network-wireless-hotspot.svg
  icons-dark/devices/22/network-wireless-hotspot.svg
  icons-dark/devices/32/network-wireless-hotspot.svg
  icons-dark/devices/8/network-wireless-hotspot.svg
  icons/devices/16/network-wireless-hotspot.svg
  icons/devices/22/network-wireless-hotspot.svg
  icons/devices/32/network-wireless-hotspot.svg
  icons/devices/8/network-wireless-hotspot.svg

To: cblack, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns