D26623: KEMailSettings: group names in kconfig files should not be localized

2020-01-23 Thread David Faure 
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  OK. I'm pretty sure this used to be shown "as is" in kmail, VERY LONG ago.

REPOSITORY
  R237 KConfig

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26623

To: meven, #frameworks, ervin, dfaure
Cc: mlaurent, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26623: KEMailSettings: group names in kconfig files should not be localized

2020-01-22 Thread Laurent Montel 
mlaurent added a comment.


  It's not used in kmail it seems.
  we use this class in kmail-account-wizard only.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D26623

To: meven, #frameworks, ervin, dfaure
Cc: mlaurent, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26623: KEMailSettings: group names in kconfig files should not be localized

2020-01-21 Thread David Faure 
dfaure added a subscriber: mlaurent.
dfaure added a comment.


  @mlaurent Does KMail show the profile name in the UI? I think this is why the 
profile name was translated, back then.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D26623

To: meven, #frameworks, ervin, dfaure
Cc: mlaurent, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26623: KEMailSettings: group names in kconfig files should not be localized

2020-01-20 Thread Kevin Ottens 
ervin added a comment.


  Inviting @dfaure in here, he was around at the time, I wasn't I started only 
the summer after. ;-)

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D26623

To: meven, #frameworks, ervin, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26623: KEMailSettings: group names in kconfig files should not be localized

2020-01-20 Thread Kevin Ottens 
ervin added a reviewer: dfaure.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D26623

To: meven, #frameworks, ervin, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26623: KEMailSettings: group names in kconfig files should not be localized

2020-01-20 Thread Kevin Ottens 
ervin added a comment.


  That being said we did that change on purpose in 2002 (commit 
38d35cec68bb718ebc97f965b66313082ab2c3b6 
 in 
kdelibs), granted xdg-email wasn't around at the time but I wonder if we thus 
want to move back from a translated "Default" name now?

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D26623

To: meven, #frameworks, ervin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26623: KEMailSettings: group names in kconfig files should not be localized

2020-01-13 Thread Méven Car 
meven retitled this revision from "KEMailSettings: key names in kconfig files 
do not need to be localized" to "KEMailSettings: group names in kconfig files 
should not be localized".

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D26623

To: meven, #frameworks, ervin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns