D26692: Fix QRegularExpression::wildcardToRegularExpression() usage
This revision was automatically updated to reflect the committed changes. Closed by commit R241:0d2959c96b6b: Fix QRegularExpression::wildcardToRegularExpression() usage (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26692?vs=73991=73992 REVISION DETAIL https://phabricator.kde.org/D26692 AFFECTED FILES src/filewidgets/kfilewidget.cpp src/kpac/script.cpp To: ahmadsamir, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D26692: Fix QRegularExpression::wildcardToRegularExpression() usage
ahmadsamir updated this revision to Diff 73991. ahmadsamir added a comment. Rebase REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26692?vs=73650=73991 BRANCH l-qregularexpression-too-wildcard (branched from master) REVISION DETAIL https://phabricator.kde.org/D26692 AFFECTED FILES src/filewidgets/kfilewidget.cpp src/kpac/script.cpp To: ahmadsamir, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D26692: Fix QRegularExpression::wildcardToRegularExpression() usage
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH l-qregularexpression-too-wildcard (branched from master) REVISION DETAIL https://phabricator.kde.org/D26692 To: ahmadsamir, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D26692: Fix QRegularExpression::wildcardToRegularExpression() usage
ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY It turns out that QRegularExpression::wildcardToRegularExpression() returns an anchored (with \A and \z) pattern, so using anchoredPattern() in such cases would actually anchor the pattern twice, which is obviously wrong. Thanks to Mikołaj Płomieński (blaze) for catching it in https://phabricator.kde.org/D26205#594891 TEST PLAN make && ctest REPOSITORY R241 KIO BRANCH l-qregularexpression-too-wildcard (branched from master) REVISION DETAIL https://phabricator.kde.org/D26692 AFFECTED FILES src/filewidgets/kfilewidget.cpp src/kpac/script.cpp To: ahmadsamir, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
