D26735: [Components 3]Make slider tickmarks optional

[George Vogiatzis]

gvgeo abandoned this revision.
gvgeo added a comment.


  Closing, when there are few steps, should be marked.
  
  > ...should be a checkbox for you?
  
  That's good idea.
  I 'll try to add a checkbox when a keyboard is on/off only.
  Not sure how it would look.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26735

To: gvgeo, #plasma, #vdg
Cc: apol, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D26735: [Components 3]Make slider tickmarks optional

[Aleix Pol Gonzalez]

apol added a comment.


  But this means that for your keyboard it's either on or off, right?
  
  This is what it looks for me. The screen has hundreds of steps so it shows 
nothing, for the keyboard it has a middle step so it's shown below. I don't 
think it should be removed.
  F7893059: IMG_20200120_000848.jpg 

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26735

To: gvgeo, #plasma, #vdg
Cc: apol, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D26735: [Components 3]Make slider tickmarks optional

[George Vogiatzis]

gvgeo added a comment.


  My case would be solved with `stepCount > 1`. But AFAIK there are keyboards 
with 3-4 steps.
  F7889338: Screenshot_20200118_064621.png 

  
  > Is there a way to achieve this with the existing qqc2 API?
  
  Not that I know. And need moved signal from it.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26735

To: gvgeo, #plasma, #vdg
Cc: apol, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D26735: [Components 3]Make slider tickmarks optional

[Aleix Pol Gonzalez]

apol added a comment.


  You should only see them if you have very a few discrete number of steps. Can 
you show a screenshot of what you see that you don't like?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26735

To: gvgeo, #plasma, #vdg
Cc: apol, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D26735: [Components 3]Make slider tickmarks optional

[David Edmundson]

davidedmundson added a comment.


  We've previously avoided adding any API to PC3 so it can be used as a 
Qqc2-style.
  
  Is there a way to achieve this with the existing qqc2 API?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26735

To: gvgeo, #plasma, #vdg
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26735: [Components 3]Make slider tickmarks optional

[George Vogiatzis]

gvgeo retitled this revision from "[Components 3]Make Slider tickmarks 
optional" to "[Components 3]Make slider tickmarks optional".

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26735

To: gvgeo, #plasma, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26735: [Components 3]Make Slider tickmarks optional

[George Vogiatzis]

gvgeo added a comment.


  Added to disable tickmarks, in battery's keyboard brightness control.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26735

To: gvgeo, #plasma, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26735: [Components 3]Make Slider tickmarks optional

[George Vogiatzis]

gvgeo created this revision.
gvgeo added reviewers: Plasma, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
gvgeo requested review of this revision.

REVISION SUMMARY
  Add tickmarksEnabled variable.

TEST PLAN
  Test with `tickmarksEnabled: false`

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  slider (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26735

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Slider.qml

To: gvgeo, #plasma, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns