D26752: ECMAddAppIcon: Do not warn about mac icons if isnt a mac build

2020-01-18 Thread Tomaz Canabrava 
tcanabrava accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  warning_icons

REVISION DETAIL
  https://phabricator.kde.org/D26752

To: patrickelectric, apol, tcanabrava
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D26752: ECMAddAppIcon: Do not warn about mac icons if isnt a mac build

2020-01-18 Thread patrick j pereira 
patrickelectric added reviewers: apol, tcanabrava.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D26752

To: patrickelectric, apol, tcanabrava
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D26752: ECMAddAppIcon: Do not warn about mac icons if isnt a mac build

2020-01-18 Thread patrick j pereira 
patrickelectric created this revision.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
patrickelectric requested review of this revision.

REVISION SUMMARY
  KSVG2ICNS will not exist if the program is not being compiled to APPLE
  
  Signed-off-by: Patrick José Pereira 
  
  ECMAddAppIcon: Do not warn about windows icons if isnt a windows build
  
  Signed-off-by: Patrick José Pereira 

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  warning_icons

REVISION DETAIL
  https://phabricator.kde.org/D26752

AFFECTED FILES
  modules/ECMAddAppIcon.cmake

To: patrickelectric
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns