D26756: Strip richtext on Windows, as Windows does not support it

2020-01-19 Thread Hannah von Reth 
vonreth added a comment.


  And here in clean with proper commits 
https://github.com/TheOneRing/knotifications/tree/rhichtext

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D26756

To: vonreth, broulik, brute4s99
Cc: nicolasfella, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26756: Strip richtext on Windows, as Windows does not support it

2020-01-19 Thread Hannah von Reth 
vonreth updated this revision to Diff 73875.
vonreth added a comment.


  - Drop dependency to KF5Codecs by using the new stripRichText function

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26756?vs=73850&id=73875

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26756

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/knotificationplugin.h
  src/notifybypopup.cpp
  src/notifybysnore.cpp

To: vonreth, broulik, brute4s99
Cc: nicolasfella, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26756: Strip richtext on Windows, as Windows does not support it

2020-01-18 Thread Nicolas Fella 
nicolasfella added a comment.


  We have the same problem on Linux (if the server doesn't support rich text) 
and probably Android too. In notifybypopup we do this with QXmlStreamReader + 
some API from KCodecs, but your solution is much simpler and nicer.
  
  Ideally this should be done in KNotification instead of the backends. 
Therefore we'd need some API in KNotificationPlugin/KNotification to indicate 
whether rich text is supported. The KNotificationManager code is quite 
convoluted currently, but it should be doable.
  
  This would help our quest of making KNotifications Tier 1 ;-)

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D26756

To: vonreth, broulik, brute4s99
Cc: nicolasfella, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26756: Strip richtext on Windows, as Windows does not support it

2020-01-18 Thread Hannah von Reth 
vonreth updated this revision to Diff 73850.
vonreth added a comment.


  Switch to QTextDocumentFragment

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26756?vs=73849&id=73850

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26756

AFFECTED FILES
  src/notifybysnore.cpp

To: vonreth, broulik, brute4s99
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26756: Strip richtext on Windows, as Windows does not support it

2020-01-18 Thread Hannah von Reth 
vonreth added reviewers: broulik, brute4s99.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D26756

To: vonreth, broulik, brute4s99
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26756: Strip richtext on Windows, as Windows does not support it

2020-01-18 Thread Hannah von Reth 
vonreth created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vonreth requested review of this revision.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26756

AFFECTED FILES
  src/notifybysnore.cpp

To: vonreth
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns