D26756: Strip richtext on Windows, simplify how rich teyt is stripped in KPassivePopup
This revision was automatically updated to reflect the committed changes. Closed by commit R289:4f2b04a171c3: Strip richtext on Windows (authored by vonreth). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D26756?vs=73885&id=73887#toc REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26756?vs=73885&id=73887 REVISION DETAIL https://phabricator.kde.org/D26756 AFFECTED FILES src/knotificationplugin.h src/notifybysnore.cpp To: vonreth, broulik, brute4s99, nicolasfella Cc: nicolasfella, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D26756: Strip richtext on Windows, simplify how rich teyt is stripped in KPassivePopup
nicolasfella accepted this revision. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D26756 To: vonreth, broulik, brute4s99, nicolasfella Cc: nicolasfella, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D26756: Strip richtext on Windows, simplify how rich teyt is stripped in KPassivePopup
vonreth updated this revision to Diff 73885. vonreth added a comment. whitespace REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26756?vs=73884&id=73885 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26756 AFFECTED FILES CMakeLists.txt src/CMakeLists.txt src/knotificationplugin.h src/notifybypopup.cpp src/notifybysnore.cpp To: vonreth, broulik, brute4s99, nicolasfella Cc: nicolasfella, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D26756: Strip richtext on Windows, simplify how rich teyt is stripped in KPassivePopup
vonreth updated this revision to Diff 73884. vonreth retitled this revision from "Strip richtext on Windows, simplify how rich teyt is stripped in KPassivePopup " to "Strip richtext on Windows, simplify how rich teyt is stripped in KPassivePopup". vonreth added a comment. Whitespace REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26756?vs=73875&id=73884 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26756 AFFECTED FILES CMakeLists.txt src/CMakeLists.txt src/knotificationplugin.h src/notifybypopup.cpp src/notifybysnore.cpp To: vonreth, broulik, brute4s99, nicolasfella Cc: nicolasfella, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D26756: Strip richtext on Windows, simplify how rich teyt is stripped in KPassivePopup
nicolasfella accepted this revision. nicolasfella added a comment. This revision is now accepted and ready to land. you can push the two commits directly INLINE COMMENTS > knotificationplugin.h:104 > + > + > Q_SIGNALS: remove one empty line > notifybysnore.cpp:62 > > + > NotifyBySnore::NotifyBySnore(QObject* parent) : unrelated REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D26756 To: vonreth, broulik, brute4s99, nicolasfella Cc: nicolasfella, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D26756: Strip richtext on Windows, simplify how rich teyt is stripped in KPassivePopup
vonreth retitled this revision from "Strip richtext on Windows, as Windows does not support it" to "Strip richtext on Windows, simplify how rich teyt is stripped in KPassivePopup ". vonreth edited the summary of this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D26756 To: vonreth, broulik, brute4s99 Cc: nicolasfella, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
