D26767: [KMessageWidget] Subtract the correct margin

2020-01-23 Thread Kai Uwe Broulik 
broulik added inline comments.

INLINE COMMENTS

> kmessagewidget.cpp:214
>"border-radius: 4px;"
>"border: 2px solid %2;"
>"margin: %3px;"

Maybe instead make the width an `int` variable and use it in both places to 
future-proof it?

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D26767

To: davidre, #frameworks, SGOrava, ngraham
Cc: broulik, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26767: [KMessageWidget] Subtract the correct margin

2020-01-23 Thread David Redondo 
This revision was automatically updated to reflect the committed changes.
Closed by commit R236:2e2f06acac60: [KMessageWidget] Subtract the correct 
margin (authored by davidre).

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26767?vs=73881&id=74195

REVISION DETAIL
  https://phabricator.kde.org/D26767

AFFECTED FILES
  src/kmessagewidget.cpp

To: davidre, #frameworks, SGOrava, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26767: [KMessageWidget] Subtract the correct margin

2020-01-20 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Ah yep, this was probably my oversight when I ported it to use the flatter 
Kirigami style.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  margins (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26767

To: davidre, #frameworks, SGOrava, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26767: [KMessageWidget] Subtract the correct margin

2020-01-19 Thread David Redondo 
davidre updated this revision to Diff 73881.
davidre added a comment.


  Update comment

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26767?vs=73880&id=73881

BRANCH
  margins (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26767

AFFECTED FILES
  src/kmessagewidget.cpp

To: davidre, #frameworks, SGOrava
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26767: [KMessageWidget] Subtract the correct margin

2020-01-19 Thread David Redondo 
davidre edited reviewers, added: SGOrava; removed: svuorela.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D26767

To: davidre, #frameworks, SGOrava, svuorela
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26767: [KMessageWidget] Subtract the correct margin

2020-01-19 Thread David Redondo 
davidre edited the test plan for this revision.
davidre added reviewers: Frameworks, svuorela.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D26767

To: davidre, #frameworks, svuorela
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26767: [KMessageWidget] Subtract the correct margin

2020-01-19 Thread David Redondo 
davidre created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidre requested review of this revision.

REVISION SUMMARY
  The comment describes a 1px border but the border actually has a size of 2px.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  margins (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26767

AFFECTED FILES
  src/kmessagewidget.cpp

To: davidre
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns