D26771: Add new signal for default action activation
This revision was automatically updated to reflect the committed changes. Closed by commit R289:a2c88d21d9b7: Add new signal for default action activation (authored by nicolasfella). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26771?vs=73893&id=74281 REVISION DETAIL https://phabricator.kde.org/D26771 AFFECTED FILES src/knotification.cpp src/knotification.h To: nicolasfella, #frameworks, broulik, davidedmundson Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D26771: Add new signal for default action activation
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH default REVISION DETAIL https://phabricator.kde.org/D26771 To: nicolasfella, #frameworks, broulik, davidedmundson Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D26771: Add new signal for default action activation
nicolasfella updated this revision to Diff 73893. nicolasfella added a comment. - Actually emit it REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26771?vs=73891&id=73893 BRANCH default REVISION DETAIL https://phabricator.kde.org/D26771 AFFECTED FILES src/knotification.cpp src/knotification.h To: nicolasfella, #frameworks, broulik, davidedmundson Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D26771: Add new signal for default action activation
davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Concept ++ I think you've missed some change in knotification.cpp to actually emit this. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D26771 To: nicolasfella, #frameworks, broulik, davidedmundson Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D26771: Add new signal for default action activation
nicolasfella created this revision. nicolasfella added reviewers: Frameworks, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY activated is an overloaded signal. Add a new signal to replace the argument-less overload. REPOSITORY R289 KNotifications BRANCH default REVISION DETAIL https://phabricator.kde.org/D26771 AFFECTED FILES src/knotification.h To: nicolasfella, #frameworks, broulik Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
