D26968: Removed hardcoded values

2020-01-28 Thread Noah Davis 
ndavis added a comment.


  In D26968#602034 , @niccolove 
wrote:
  
  > Okay! I'm installing Inkscape 1, for future patches. May I ask you to land 
this, as I don't have access rights?
  
  
  Sure. Do you not have a KDE developer account?

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fix_panel_color

REVISION DETAIL
  https://phabricator.kde.org/D26968

To: niccolove, #vdg, #plasma, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26968: Removed hardcoded values

2020-01-28 Thread Niccolò Venerandi 
niccolove added a comment.


  Okay! I'm installing Inkscape 1, for future patches. May I ask you to land 
this, as I don't have access rights?

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fix_panel_color

REVISION DETAIL
  https://phabricator.kde.org/D26968

To: niccolove, #vdg, #plasma, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26968: Removed hardcoded values

2020-01-28 Thread Noah Davis 
ndavis added a comment.


  Anyway, it works as it is, so don't worry about it.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fix_panel_color

REVISION DETAIL
  https://phabricator.kde.org/D26968

To: niccolove, #vdg, #plasma, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26968: Removed hardcoded values

2020-01-28 Thread Noah Davis 
ndavis added a comment.


  In D26968#602031 , @niccolove 
wrote:
  
  > In D26968#601998 , @ndavis wrote:
  >
  > > You should remove the color field instead of using `color:currentColor` 
and `fill:currentColor`
  >
  >
  > I tried to do that, but for some reason the "color:#effeff" automatically 
appears again (in inkscape) :-/
  
  
  Yeah, you have to remove it with `sed` or a text editor every time unless you 
use Inkscape 1.0

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fix_panel_color

REVISION DETAIL
  https://phabricator.kde.org/D26968

To: niccolove, #vdg, #plasma, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26968: Removed hardcoded values

2020-01-28 Thread Niccolò Venerandi 
niccolove added a comment.


  In D26968#601998 , @ndavis wrote:
  
  > You should remove the color field instead of using `color:currentColor` and 
`fill:currentColor`
  
  
  I tried to do that, but for some reason the "color:#effeff" automatically 
appears again (in inkscape) :-/

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fix_panel_color

REVISION DETAIL
  https://phabricator.kde.org/D26968

To: niccolove, #vdg, #plasma, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26968: Removed hardcoded values

2020-01-28 Thread Noah Davis 
ndavis added reviewers: VDG, Plasma.
ndavis added a comment.


  This does have rounded corners and the background is fixed.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26968

To: niccolove, #vdg, #plasma
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26968: Removed hardcoded values

2020-01-28 Thread Noah Davis 
ndavis accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fix_panel_color

REVISION DETAIL
  https://phabricator.kde.org/D26968

To: niccolove, #vdg, #plasma, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26968: Removed hardcoded values

2020-01-28 Thread Noah Davis 
ndavis added a comment.


  You should remove the color field instead of using `color:currentColor` and 
`fill:currentColor`

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26968

To: niccolove
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26968: Removed hardcoded values

2020-01-28 Thread Niccolò Venerandi 
niccolove created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
niccolove requested review of this revision.

REVISION SUMMARY
  Alternative and more basic patch to D26955 
, this aims to fix the background color 
without breaking the mask

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fix_panel_color

REVISION DETAIL
  https://phabricator.kde.org/D26968

AFFECTED FILES
  src/desktoptheme/breeze/translucent/widgets/panel-background.svg
  src/desktoptheme/breeze/translucent/widgets/tooltip.svg

To: niccolove
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns