D27039: [KStyle] Set the color of KMessageWidgets to the correct one from the current color scheme

2020-02-25 Thread David Redondo 
This revision was automatically updated to reflect the committed changes.
Closed by commit R252:d3a1b5148008: [KStyle] Set the color of KMessageWidgets 
to the correct one from the current… (authored by davidre).

REPOSITORY
  R252 Framework Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27039?vs=74713=76410

REVISION DETAIL
  https://phabricator.kde.org/D27039

AFFECTED FILES
  src/kstyle/kstyle.cpp

To: davidre, #frameworks, aacid, anthonyfieroni, apol
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27039: [KStyle] Set the color of KMessageWidgets to the correct one from the current color scheme

2020-02-24 Thread Aleix Pol Gonzalez 
apol accepted this revision.

REPOSITORY
  R252 Framework Integration

BRANCH
  messagewidget (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27039

To: davidre, #frameworks, aacid, anthonyfieroni, apol
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27039: [KStyle] Set the color of KMessageWidgets to the correct one from the current color scheme

2020-02-23 Thread Anthony Fieroni 
anthonyfieroni accepted this revision.
anthonyfieroni added a comment.
This revision is now accepted and ready to land.


  No, just to not reviewed only by me.

REPOSITORY
  R252 Framework Integration

BRANCH
  messagewidget (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27039

To: davidre, #frameworks, aacid, anthonyfieroni
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27039: [KStyle] Set the color of KMessageWidgets to the correct one from the current color scheme

2020-02-22 Thread Albert Astals Cid 
aacid added a comment.


  Any particular reason you added me?

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D27039

To: davidre, #frameworks, aacid
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27039: [KStyle] Set the color of KMessageWidgets to the correct one from the current color scheme

2020-02-22 Thread Anthony Fieroni 
anthonyfieroni added a reviewer: aacid.
anthonyfieroni added a comment.


  +1

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D27039

To: davidre, #frameworks, aacid
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27039: [KStyle] Set the color of KMessageWidgets to the correct one from the current color scheme

2020-02-22 Thread David Redondo 
davidre added a comment.


  Ping

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D27039

To: davidre, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27039: [KStyle] Set the color of KMessageWidgets to the correct one from the current color scheme

2020-01-30 Thread David Redondo 
davidre updated this revision to Diff 74713.
davidre added a comment.


  Fix code style

REPOSITORY
  R252 Framework Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27039?vs=74704=74713

BRANCH
  messagewidget (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27039

AFFECTED FILES
  src/kstyle/kstyle.cpp

To: davidre, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27039: [KStyle] Set the color of KMessageWidgets to the correct one from the current color scheme

2020-01-30 Thread David Redondo 
davidre added a dependency: D27038: [KMessageWidget] Allow the style to change 
our palette.

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D27039

To: davidre, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27039: [KStyle] Set the color of KMessageWidgets to the correct one from the current color scheme

2020-01-30 Thread David Redondo 
davidre edited the test plan for this revision.

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D27039

To: davidre, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27039: [KStyle] Set the color of KMessageWidgets to the correct one from the current color scheme

2020-01-30 Thread David Redondo 
davidre created this revision.
davidre added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidre requested review of this revision.

REVISION SUMMARY
  KMessageWidget has to rely on hardcoded colors because it's in a Tier 1 
framework.
  However after determining its color it will give the style a chance to set a
  better fitting color by calling polish. So set it's color to the appropriate
  one from the current color scheme.

TEST PLAN
  KmessageWidget follows Color Scheme

REPOSITORY
  R252 Framework Integration

BRANCH
  messagewidget (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27039

AFFECTED FILES
  src/kstyle/kstyle.cpp

To: davidre, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns