D27067: Change "AutoSkip" to "Skip All"

2020-02-07 Thread Nathaniel Graham 
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:2c84f4b1c8fb: Change "AutoSkip" to "Skip 
All" (authored by ngraham).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27067?vs=74781&id=75161

REVISION DETAIL
  https://phabricator.kde.org/D27067

AFFECTED FILES
  src/widgets/skipdialog.cpp

To: ngraham, #frameworks, #vdg, dfaure, apol
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27067: Change "AutoSkip" to "Skip All"

2020-02-07 Thread Aleix Pol Gonzalez 
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27067

To: ngraham, #frameworks, #vdg, dfaure, apol
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27067: Change "AutoSkip" to "Skip All"

2020-02-06 Thread Nathaniel Graham 
ngraham added a comment.


  Ping.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27067

To: ngraham, #frameworks, #vdg, dfaure
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27067: Change "AutoSkip" to "Skip All"

2020-01-31 Thread Nathaniel Graham 
ngraham added a comment.


  Sure, in another patch. :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27067

To: ngraham, #frameworks, #vdg, dfaure
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27067: Change "AutoSkip" to "Skip All"

2020-01-31 Thread Kai Uwe Broulik 
broulik added a comment.


  +1 (also for considering the string freeze :)
  
  I think we should add some mnemonics, i.e. "&Skip" and "Skip &all"

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27067

To: ngraham, #frameworks, #vdg, dfaure
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27067: Change "AutoSkip" to "Skip All"

2020-01-31 Thread Nathaniel Graham 
ngraham created this revision.
ngraham added reviewers: Frameworks, VDG, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  "AutoSkip" is not a word and makes it unclear what the button actually does.
  
  BUG: 416964
  FIXED-IN: 5.68

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27067

AFFECTED FILES
  src/widgets/skipdialog.cpp

To: ngraham, #frameworks, #vdg, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns