D27082: [Tests]Make radiobutton3.qml use PC3

2020-02-04 Thread Nathaniel Graham 
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:dccf6c4dd629: [Tests]Make radiobutton3.qml use PC3 
(authored by gvgeo, committed by ngraham).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27082?vs=74826=75006

REVISION DETAIL
  https://phabricator.kde.org/D27082

AFFECTED FILES
  tests/components/radiobutton3.qml

To: gvgeo, #plasma, davidedmundson
Cc: ngraham, davidedmundson, ndavis, kde-frameworks-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
michaelh, ZrenBot, bruns, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27082: [Tests]Make radiobutton3.qml use PC3

2020-02-04 Thread Nathaniel Graham 
ngraham added a comment.


  All right, your choice. I'll land this for you now. Great work!

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  radiobutton (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27082

To: gvgeo, #plasma, davidedmundson
Cc: ngraham, davidedmundson, ndavis, kde-frameworks-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
michaelh, ZrenBot, bruns, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27082: [Tests]Make radiobutton3.qml use PC3

2020-02-03 Thread George Vogiatzis 
gvgeo added a comment.


  I 'll ask you to keep committing my patches a little longer.
  At least for my current patches, and their related bugfixes.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  radiobutton (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27082

To: gvgeo, #plasma, davidedmundson
Cc: ngraham, davidedmundson, ndavis, kde-frameworks-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, michaelh, 
ZrenBot, bruns, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D27082: [Tests]Make radiobutton3.qml use PC3

2020-02-03 Thread Nathaniel Graham 
ngraham added a comment.


  Additional documentation is at 
https://community.kde.org/Infrastructure/Get_a_Developer_Account
  
  Definitely apply! You've earned it.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  radiobutton (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27082

To: gvgeo, #plasma, davidedmundson
Cc: ngraham, davidedmundson, ndavis, kde-frameworks-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, michaelh, 
ZrenBot, bruns, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D27082: [Tests]Make radiobutton3.qml use PC3

2020-02-03 Thread David Edmundson 
davidedmundson added a comment.


  > I can't do that, someone else need to commit it.
  
  Then lets fix that.
  
  You can apply for a developer account (there should be a button on 
identity.kde.org) and tag me and Nate as approvers.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  radiobutton (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27082

To: gvgeo, #plasma, davidedmundson
Cc: davidedmundson, ndavis, kde-frameworks-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, michaelh, 
ZrenBot, ngraham, bruns, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27082: [Tests]Make radiobutton3.qml use PC3

2020-02-03 Thread George Vogiatzis 
gvgeo added a comment.


  > Ship it!
  
  I can't do that, someone else need to commit it.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  radiobutton (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27082

To: gvgeo, #plasma, davidedmundson
Cc: davidedmundson, ndavis, kde-frameworks-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, michaelh, 
ZrenBot, ngraham, bruns, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27082: [Tests]Make radiobutton3.qml use PC3

2020-02-02 Thread David Edmundson 
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Regardless of issues, the change for the test is correct.
  
  We should break the test to highlight issues. Ship it!

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  radiobutton (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27082

To: gvgeo, #plasma, davidedmundson
Cc: davidedmundson, ndavis, kde-frameworks-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, michaelh, 
ZrenBot, ngraham, bruns, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27082: [Tests]Make radiobutton3.qml use PC3

2020-02-01 Thread George Vogiatzis 
gvgeo removed a reviewer: ndavis.
gvgeo added a subscriber: ndavis.
gvgeo added a comment.


  
  
  In D27082#604556 , @ndavis wrote:
  
  > poor horizontal alignment
  
  
  Don't make me redraw PC3 tests too. The basis of the issue is the same, 
different Label than Button height. For PC3 label is shorter than buttons.
  
  In D26758#604416 , @gvgeo wrote:
  
  > F8071207: alignment.png 
  >  This shows the problem.
  >  Don't know what is the correct approach:
  >  1 Label needs to be shorter.
  >  2 Give correct height in checkbox, and center the buttons.
  >  3 Override label height in radiobutton, to make everything slim. Will need 
to center when used.
  
  
  Either need to increase label height to button height, or need to center 
label in the test (and everywhere else it is used.)
  
  ---
  
  In D27082#604557 , @ndavis wrote:
  
  > Well, it has the correct size in that it's 16x16, but it's like it was 
stretched and crop
  
  
  Others would say "The position of the left side is off by half a pixel".
  The cause of it and solution, as I interpret them is D27083 
.
  
  ---
  
  In D27082#604556 , @ndavis wrote:
  
  > I'm not really the best person to review this
  
  
  I made these 2 patches based on your feedback, and thought  it would be a 
good idea to see them. There, fixed it :)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27082

To: gvgeo, #plasma
Cc: ndavis, kde-frameworks-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, michaelh, ZrenBot, ngraham, bruns, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27082: [Tests]Make radiobutton3.qml use PC3

2020-02-01 Thread Noah Davis 
ndavis added a comment.


  Well, it has the correct size in that it's 16x16, but it's like it was 
stretched and cropped.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27082

To: gvgeo, #plasma, ndavis
Cc: kde-frameworks-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, michaelh, ZrenBot, ngraham, bruns, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27082: [Tests]Make radiobutton3.qml use PC3

2020-02-01 Thread Noah Davis 
ndavis added a comment.


  I'm not really the best person to review this, but it seems to work. The test 
still has poor horizontal alignment and the button doesn't have the correct 
size. F8074583: Screenshot_20200201_142426.PNG 


REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27082

To: gvgeo, #plasma, ndavis
Cc: kde-frameworks-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, michaelh, ZrenBot, ngraham, bruns, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27082: [Tests]Make radiobutton3.qml use PC3

2020-02-01 Thread George Vogiatzis 
gvgeo retitled this revision from "Make radiobutton3.qml use PC3" to 
"[Tests]Make radiobutton3.qml use PC3".
gvgeo edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27082

To: gvgeo, #plasma, ndavis
Cc: kde-frameworks-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, michaelh, ZrenBot, ngraham, bruns, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart