D27255: nota

2020-03-20 Thread Noah Davis 
ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  LGTM

REPOSITORY
  R266 Breeze Icons

BRANCH
  nota (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27255

To: mbruchert, camiloh, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D27255: nota

2020-03-20 Thread Mathis Brüchert 
mbruchert updated this revision to Diff 78083.
mbruchert added a comment.


  - update dotted lines

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27255?vs=75271=78083

BRANCH
  nota (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27255

AFFECTED FILES
  icons-dark/apps/48/nota.svg
  icons/apps/48/nota.svg

To: mbruchert, camiloh, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D27255: nota

2020-03-19 Thread Noah Davis 
ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.


  The dotted lines are placed on half pixels, which we should avoid doing.
  Depending on the look you're going for, you could do either one of the 
following:
  
  - Align the 1px thick lines to the pixel grid
  - Expand the dotted lines to 2px thickness and set their opacity to 50%. This 
preserves the current look and make it continue to look that way at larger 
scales.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27255

To: mbruchert, camiloh, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D27255: nota

2020-03-19 Thread Nathaniel Graham 
ngraham added subscribers: ndavis, ngraham.
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  LGTM. @ndavis?

REPOSITORY
  R266 Breeze Icons

BRANCH
  nota (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27255

To: mbruchert, camiloh, #vdg, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D27255: nota

2020-02-11 Thread Mathis Brüchert 
mbruchert added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27255

To: mbruchert, camiloh, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27255: nota

2020-02-08 Thread Mathis Brüchert 
mbruchert added a reviewer: camiloh.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27255

To: mbruchert, camiloh
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27255: nota

2020-02-08 Thread Mathis Brüchert 
mbruchert added a comment.


  F8092229: image.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27255

To: mbruchert
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27255: nota

2020-02-08 Thread Mathis Brüchert 
mbruchert created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mbruchert requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  nota (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27255

AFFECTED FILES
  icons-dark/apps/48/nota.svg
  icons/apps/48/nota.svg

To: mbruchert
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns